Utilize InlineBoxTraversal in {Left,Right}PositionOf() left/right traversal

Utilize InlineBoxTraversal in {Left,Right}PositionOf() left/right traversal

This patch utilizes |Find{Left,Right}BoundaryOfEntireBidiRun()| in
|TraverseInternalAlgorithm()| for |{Left,Right}PositionOf()| in
|SelectionModifier| class to avoid common pattern for improving code health.


BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2944563002
Cr-Commit-Position: refs/heads/master@{#479993}
Committed: https://chromium.googlesource.com/chromium/src/+/13729cdfbd63d6814a5a09e764e012b142576f34

[yosin_UTC9, 2017-06-16 03:41:27]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 03:41:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-16 04:36:33]

Description was changed from

==========
2017-06-16T12:38:41

BUG=

2017-06-16T12:38:22
==========

to

==========
Utilize InlineBoxTraversal in {Left,Right}PositionOf() left/right traversal

This patch utilizes |Find{Left,Right}BoundaryOfEntireBidiRun()| in
|TraverseInternalAlgorithm()| for |{Left,Right}PositionOf()| in
|SelectionModifier| class to avoid common pattern for improving code health.


BUG=707656
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-06-16 04:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 04:39:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-06-16 05:11:46]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-16 05:11:47]

PTAL

[yoichio, 2017-06-16 05:32:02]

On 2017/06/16 05:11:47, yosin_UTC9 wrote:
> PTAL

Looks good but 
InlineBoxTraversal.cpp defines struct TraverseLeft  and 
SelectionModifierCharacter.cpp defines struct TraversalLeft.
This is very confusing. Do you have plan to clean up?

[yosin_UTC9, 2017-06-16 05:39:34]

On 2017/06/16 at 05:32:02, yoichio wrote:
> On 2017/06/16 05:11:47, yosin_UTC9 wrote:
> > PTAL
> 
> Looks good but 
> InlineBoxTraversal.cpp defines struct TraverseLeft  and 
> SelectionModifierCharacter.cpp defines struct TraversalLeft.
> This is very confusing. Do you have plan to clean up?

No, I have no plan. Both of them are different files and isolated.
If you have a suggested name, I'll replace it.

[yoichio, 2017-06-16 06:24:34]

lgtm

[yosin_UTC9, 2017-06-16 06:32:20]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-16 06:32:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 08:19:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497594740377480, "parent_rev":
"b2686b1a99529d3f57301d6fe54c6b4962ca8018", "commit_rev":
"13729cdfbd63d6814a5a09e764e012b142576f34"}

[commit-bot: I haz the power, 2017-06-16 08:19:59]

Description was changed from

==========
Utilize InlineBoxTraversal in {Left,Right}PositionOf() left/right traversal

This patch utilizes |Find{Left,Right}BoundaryOfEntireBidiRun()| in
|TraverseInternalAlgorithm()| for |{Left,Right}PositionOf()| in
|SelectionModifier| class to avoid common pattern for improving code health.


BUG=707656
TEST=n/a; no behavior changes
==========

to

==========
Utilize InlineBoxTraversal in {Left,Right}PositionOf() left/right traversal

This patch utilizes |Find{Left,Right}BoundaryOfEntireBidiRun()| in
|TraverseInternalAlgorithm()| for |{Left,Right}PositionOf()| in
|SelectionModifier| class to avoid common pattern for improving code health.


BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2944563002
Cr-Commit-Position: refs/heads/master@{#479993}
Committed:
https://chromium.googlesource.com/chromium/src/+/13729cdfbd63d6814a5a09e764e0...
==========

[commit-bot: I haz the power, 2017-06-16 08:20:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13729cdfbd63d6814a5a09e764e0...