Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2944553003: cros: Enable Ext4 migration in ARC kiosk mode. (Closed)

Created:
3 years, 6 months ago by fukino
Modified:
3 years, 5 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, poromov+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, kinaba
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Enable Ext4 dircrypto migration for ARC kiosk mode. When old encryption is detected in ARC kiosk session, we should migrate the encryption. As it is for kiosk situation, we skip all checks (user confirmation, battery, and space) and start migration immediately. This CL also adds UMA stats for the kiosk migration. BUG=730966 TEST=manually tested by following https://docs.google.com/document/d/1JS6wtZ6VxKDN0SvphuvvydixPkiTwlxzJ17DZUsMEzM/edit# Review-Url: https://codereview.chromium.org/2944553003 Cr-Commit-Position: refs/heads/master@{#482856} Committed: https://chromium.googlesource.com/chromium/src/+/9a07fb43185f855ed04446008efebf80564ef3c9

Patch Set 1 #

Patch Set 2 : Add UMA. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -26 lines) Patch
M chrome/browser/chromeos/login/arc_kiosk_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/arc_kiosk_controller.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc View 1 12 chunks +114 lines, -26 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
fukino
xiyuan@, could you take a look? isherman@, could you take a look at histograms? Thanks!
3 years, 6 months ago (2017-06-16 10:18:00 UTC) #4
xiyuan
lgtm
3 years, 6 months ago (2017-06-16 17:39:56 UTC) #5
Ilya Sherman
On 2017/06/16 10:18:00, fukino wrote: > isherman@, could you take a look at histograms? You ...
3 years, 6 months ago (2017-06-16 21:08:43 UTC) #6
fukino
Thank you for the review! I'll commit this after https://chromium-review.googlesource.com/c/527754/ lands.
3 years, 6 months ago (2017-06-19 02:22:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944553003/20001
3 years, 5 months ago (2017-06-28 01:24:55 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 02:34:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a07fb43185f855ed04446008efe...

Powered by Google App Engine
This is Rietveld 408576698