Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2944443002: Add NetLog events for HttpStreamFactoryImpl::Job throttle logic (Closed)

Created:
3 years, 6 months ago by xunjieli
Modified:
3 years, 6 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, eroman, mmenke, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NetLog events for HttpStreamFactoryImpl::Job throttle logic This CL adds two NetLog events for HttpStreamFactoryImpl::Job throttle logic. (1) HTTP_STREAM_JOB_THROTTLED: emitted when Job is throttled. (2) HTTP_STREAM_JOB_RESUME_INIT_CONNECTION: emitted when Job is unblocked from being previously throttled. BUG=718576 Review-Url: https://codereview.chromium.org/2944443002 Cr-Commit-Position: refs/heads/master@{#479820} Committed: https://chromium.googlesource.com/chromium/src/+/16dc7c64578e96b27565f3a66f6134c817998274

Patch Set 1 #

Patch Set 2 : self #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/log/net_log_event_type_list.h View 1 chunk +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
xunjieli
Bence, PTAL. Thank you.
3 years, 6 months ago (2017-06-15 14:49:32 UTC) #5
xunjieli
On 2017/06/15 14:49:32, xunjieli wrote: > Bence, PTAL. Thank you. Here's an example NetLog: https://drive.google.com/a/google.com/file/d/0B_9WseIqRoaFMS0wZ1hEb2NtRk0/view?usp=sharing ...
3 years, 6 months ago (2017-06-15 15:07:50 UTC) #6
Bence
LGTM
3 years, 6 months ago (2017-06-15 15:22:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944443002/20001
3 years, 6 months ago (2017-06-15 18:25:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/238415)
3 years, 6 months ago (2017-06-15 19:22:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944443002/20001
3 years, 6 months ago (2017-06-15 19:25:14 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 20:47:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16dc7c64578e96b27565f3a66f61...

Powered by Google App Engine
This is Rietveld 408576698