Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2944403002: Add GetLog method call to DebugDaemonClient (Closed)

Created:
3 years, 6 months ago by Simon Que
Modified:
3 years, 6 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GetLog method call to DebugDaemonClient This gets an individual log from debugd. BUG=733846 Review-Url: https://codereview.chromium.org/2944403002 Cr-Commit-Position: refs/heads/master@{#481805} Committed: https://chromium.googlesource.com/chromium/src/+/f11d62080a80c7de948ec4c4d7e9c1673becb257

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Return success=true in FakeDebugDaemonClient::GetLog() #

Total comments: 2

Patch Set 4 : Use separate callback type with string parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M chromeos/dbus/debug_daemon_client.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chromeos/dbus/debug_daemon_client.cc View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_debug_daemon_client.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_debug_daemon_client.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Simon Que
3 years, 6 months ago (2017-06-20 16:51:38 UTC) #2
Simon Que
Not ready yet. stevenjb, I will add you back when it's ready.
3 years, 6 months ago (2017-06-20 17:00:39 UTC) #4
Simon Que
3 years, 6 months ago (2017-06-20 21:08:09 UTC) #6
Simon Que
3 years, 6 months ago (2017-06-22 22:20:20 UTC) #8
Daniel Erat
https://codereview.chromium.org/2944403002/diff/40001/chromeos/dbus/debug_daemon_client.cc File chromeos/dbus/debug_daemon_client.cc (right): https://codereview.chromium.org/2944403002/diff/40001/chromeos/dbus/debug_daemon_client.cc#newcode651 chromeos/dbus/debug_daemon_client.cc:651: result[log_name] = result_string; returning a single-entry map feels a ...
3 years, 6 months ago (2017-06-23 01:04:27 UTC) #9
Simon Que
https://codereview.chromium.org/2944403002/diff/40001/chromeos/dbus/debug_daemon_client.cc File chromeos/dbus/debug_daemon_client.cc (right): https://codereview.chromium.org/2944403002/diff/40001/chromeos/dbus/debug_daemon_client.cc#newcode651 chromeos/dbus/debug_daemon_client.cc:651: result[log_name] = result_string; On 2017/06/23 01:04:27, Daniel Erat wrote: ...
3 years, 6 months ago (2017-06-23 01:15:10 UTC) #10
Daniel Erat
lgtm thanks!
3 years, 6 months ago (2017-06-23 01:26:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944403002/60001
3 years, 6 months ago (2017-06-23 03:37:38 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 03:42:10 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f11d62080a80c7de948ec4c4d7e9...

Powered by Google App Engine
This is Rietveld 408576698