Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5149)

Unified Diff: chrome/browser/installable/installable_manager_browsertest.cc

Issue 2944283002: Replace --add-to-shelf flag with kAppBanners feature. (Closed)
Patch Set: Self nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager_browsertest.cc
diff --git a/chrome/browser/installable/installable_manager_browsertest.cc b/chrome/browser/installable/installable_manager_browsertest.cc
index 58cabb85b4996b4dd1ff2f2960ffff70113aa860..b574ca79677b8111f2072f13fc1763248a9ce4e3 100644
--- a/chrome/browser/installable/installable_manager_browsertest.cc
+++ b/chrome/browser/installable/installable_manager_browsertest.cc
@@ -6,10 +6,11 @@
#include "base/command_line.h"
#include "base/run_loop.h"
+#include "base/test/scoped_feature_list.h"
#include "base/threading/thread_task_runner_handle.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/common/chrome_switches.h"
+#include "chrome/common/chrome_features.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
@@ -157,6 +158,10 @@ class InstallableManagerBrowserTest : public InProcessBrowserTest {
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
ASSERT_TRUE(embedded_test_server()->Start());
+
+ // Make sure app banners are disabled in the browser so they do not
+ // interfere with the test.
+ feature_list_.InitAndDisableFeature(features::kAppBanners);
}
// Returns a test server URL to a page controlled by a service worker with
@@ -183,12 +188,6 @@ class InstallableManagerBrowserTest : public InProcessBrowserTest {
base::Unretained(tester)));
}
- void SetUpCommandLine(base::CommandLine* command_line) override {
- // Make sure app banners are disabled in the browser so they do not
- // interfere with the test.
- command_line->AppendSwitch(switches::kDisableAddToShelf);
- }
-
InstallableManager* GetManager() {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
@@ -201,6 +200,9 @@ class InstallableManagerBrowserTest : public InProcessBrowserTest {
}
InstallabilityCheckStatus GetStatus() { return GetManager()->page_status_; }
+
+ private:
+ base::test::ScopedFeatureList feature_list_;
};
IN_PROC_BROWSER_TEST_F(InstallableManagerBrowserTest,

Powered by Google App Engine
This is Rietveld 408576698