Replace --add-to-shelf flag with kAppBanners feature.

chrome/renderer/web_apps.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/web_apps.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 132 matching lines @@
 
     if (elem.HasHTMLTagName("link")) {
       std::string rel = elem.GetAttribute("rel").Utf8();
       // "rel" attribute may use either "icon" or "shortcut icon".
       // see also
       //   <http://en.wikipedia.org/wiki/Favicon>
       //   <http://dev.w3.org/html5/spec/Overview.html#rel-icon>
       //
       // Bookmark apps also support "apple-touch-icon" and
       // "apple-touch-icon-precomposed".
 #if defined(OS_MACOSX)

[Lei Zhang, 2017/06/22 07:21:05]

Side question 2: This looks just like IsNewBookmarkAppsEnabled(). Did we ever
discuss moving that to chrome/common?

[benwells, 2017/06/22 07:34:10]

Good question. Currently IsNewBookmarkAppsEnabled is in
c/b/extensions/extension_util. We could create
c/common/extensions/extension_util, or do you have a better place to put it?

       bool bookmark_apps_enabled =

[Lei Zhang, 2017/06/22 07:21:05]

Side question 1: Can we move this out of the for-loop?

-          base::FeatureList::IsEnabled(features::kBookmarkApps);
+          base::FeatureList::IsEnabled(features::kBookmarkApps) ||
+          base::FeatureList::IsEnabled(features::kAppBanners);
 #else
       bool bookmark_apps_enabled = true;
 #endif
       if (base::LowerCaseEqualsASCII(rel, "icon") ||
           base::LowerCaseEqualsASCII(rel, "shortcut icon") ||
           (bookmark_apps_enabled &&
            (base::LowerCaseEqualsASCII(rel, "apple-touch-icon") ||
             base::LowerCaseEqualsASCII(rel, "apple-touch-icon-precomposed")))) {
         AddInstallIcon(elem, &app_info->icons);
       }
@@ skipping 17 matching lines @@
                  base::LowerCaseEqualsASCII(content.Utf16(), "yes") &&
                  app_info->mobile_capable ==
                      WebApplicationInfo::MOBILE_CAPABLE_UNSPECIFIED) {
         app_info->mobile_capable = WebApplicationInfo::MOBILE_CAPABLE_APPLE;
       }
     }
   }
 }
 
 }  // namespace web_apps