Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8313)

Unified Diff: chrome/renderer/web_apps.cc

Issue 2944283002: Replace --add-to-shelf flag with kAppBanners feature. (Closed)
Patch Set: Double Doh! Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/web_apps.cc
diff --git a/chrome/renderer/web_apps.cc b/chrome/renderer/web_apps.cc
index 43c6056cce99f2d4db846a9c291f9c6c0ad72130..a5356139355e99e4b909a954fb2f959fcda316fc 100644
--- a/chrome/renderer/web_apps.cc
+++ b/chrome/renderer/web_apps.cc
@@ -152,7 +152,8 @@ void ParseWebAppFromWebDocument(WebFrame* frame,
// "apple-touch-icon-precomposed".
#if defined(OS_MACOSX)
Lei Zhang 2017/06/22 07:21:05 Side question 2: This looks just like IsNewBookmar
benwells 2017/06/22 07:34:10 Good question. Currently IsNewBookmarkAppsEnabled
bool bookmark_apps_enabled =
Lei Zhang 2017/06/22 07:21:05 Side question 1: Can we move this out of the for-l
- base::FeatureList::IsEnabled(features::kBookmarkApps);
+ base::FeatureList::IsEnabled(features::kBookmarkApps) ||
+ base::FeatureList::IsEnabled(features::kAppBanners);
#else
bool bookmark_apps_enabled = true;
#endif

Powered by Google App Engine
This is Rietveld 408576698