Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2944153002: Mojo JS bindings: introduce new targets "foo_js"/"foo_js_data_deps" for mojom("foo"). (Closed)

Created:
3 years, 6 months ago by yzshen1
Modified:
3 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: introduce new targets "foo_js"/"foo_js_data_deps" for mojom("foo"). foo_js: JavaScript bindings; used as compile-time deps. foo_js_data_deps: JavaScript bindings; used as run-time deps. The target "foo" no longer generates the JS code or declare the JS code as runtime deps. BUG=603212 Review-Url: https://codereview.chromium.org/2944153002 Cr-Commit-Position: refs/heads/master@{#481277} Committed: https://chromium.googlesource.com/chromium/src/+/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -52 lines) Patch
M BUILD.gn View 1 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +7 lines, -10 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download
M headless/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/test/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 1 2 chunks +7 lines, -8 lines 0 comments Download
M mojo/public/js/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 2 3 10 chunks +72 lines, -16 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
yzshen1
Hi, reviewers. Would you please take a look? - Brett: GN usage, and OWNER for ...
3 years, 6 months ago (2017-06-20 21:56:09 UTC) #13
Ken Rockot(use gerrit already)
lgtm
3 years, 6 months ago (2017-06-20 23:33:39 UTC) #16
brettw
lgtm
3 years, 6 months ago (2017-06-21 19:32:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944153002/60001
3 years, 6 months ago (2017-06-21 19:33:21 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 19:38:41 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9e737bfc5e4d818bc14f8282c4a0...

Powered by Google App Engine
This is Rietveld 408576698