Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2944033004: clang/win: Temporarily slow down renderer startup by 0.1s (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, hans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Temporarily slow down renderer startup by 0.1s We're trying to understand why a certain metric is a bit higher with clang than with MSVC. We think this might be due to slower renderer startup, but we're not sure. Slow down renderer startup so we can measure if this is the reason. BUG=728324 Review-Url: https://codereview.chromium.org/2944033004 Cr-Commit-Position: refs/heads/master@{#480707} Committed: https://chromium.googlesource.com/chromium/src/+/51a2f1e6d3a9edc207bbc096a827153b1a23d316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/renderer/renderer_main.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
3 years, 6 months ago (2017-06-20 00:03:49 UTC) #3
Nico
+kinuko as a more in-time-zone reviewer since we're hoping to get this into tomorrow's dev ...
3 years, 6 months ago (2017-06-20 00:10:30 UTC) #6
Avi (use Gerrit)
That's one way to do it. LGTM
3 years, 6 months ago (2017-06-20 00:14:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2944033004/1
3 years, 6 months ago (2017-06-20 00:15:09 UTC) #10
kinuko
(lgtm/2)
3 years, 6 months ago (2017-06-20 02:15:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/51a2f1e6d3a9edc207bbc096a827153b1a23d316
3 years, 6 months ago (2017-06-20 03:18:24 UTC) #14
Nico
3 years, 6 months ago (2017-06-20 20:48:17 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2949913002/ by thakis@chromium.org.

The reason for reverting is: Dev channel was cut..

Powered by Google App Engine
This is Rietveld 408576698