Fixes for super tearoff in constructor

Fixes for super tearoff in constructor

Fixes #29932

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/ed8de04f084360d8756d8fd18d32ec11c7882840

[vsm, 2017-06-19 20:12:16]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[vsm, 2017-06-19 20:12:45]

Description was changed from

==========
Fixes #29932
==========

to

==========
Fixes for super tearoff in constructor

Fixes #29932
==========

[Jennifer Messerly, 2017-06-19 20:24:53]

https://codereview.chromium.org/2944003003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2944003003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:4831: if (!_superAllowed
&& jsTarget is JS.Super) {
You could refactor this entire code block, replacing with:

if (isSuper) {
  result = _callHelper('bind(this, #, #)',
      [safeName, _emitTargetAccess(jsTarget, name, accessor)]);
} ...


(note: you should not need to pass `safeName` to _emitTargetAccess. The
`safeName` workaround is purely for the `dart.bind` call.)

(note2: frankly, I think `safeName` is not a correct workaround, and someone
added this because they didn't understand how to fix `dart.bind`. Either that or
it dates back to the "angular whitelist hack" that resulted in tons of bogus
extension method handling everywhere =\ )

https://codereview.chromium.org/2944003003/diff/1/tests/language_strong/super...
File tests/language_strong/super_tearoff_test.dart (right):

https://codereview.chromium.org/2944003003/diff/1/tests/language_strong/super...
tests/language_strong/super_tearoff_test.dart:1: import
'package:expect/expect.dart';
this needs a copyright notice

alternatively, I think you could easily add this to an existing test. I always
try and consolidate very simple tests, because compiling+running individual
language tests adds lots of buildbot and iteration cycle slowness.

super_from_constructor_test.dart seems like a good place :)

[vsm, 2017-06-19 20:36:20]

PTAL

https://codereview.chromium.org/2944003003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2944003003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:4831: if (!_superAllowed
&& jsTarget is JS.Super) {
On 2017/06/19 20:24:52, Jennifer Messerly wrote:
> You could refactor this entire code block, replacing with:
> 
> if (isSuper) {
>   result = _callHelper('bind(this, #, #)',
>       [safeName, _emitTargetAccess(jsTarget, name, accessor)]);
> } ...
> 
> 
> (note: you should not need to pass `safeName` to _emitTargetAccess. The
> `safeName` workaround is purely for the `dart.bind` call.)
> 
> (note2: frankly, I think `safeName` is not a correct workaround, and someone
> added this because they didn't understand how to fix `dart.bind`. Either that
or
> it dates back to the "angular whitelist hack" that resulted in tons of bogus
> extension method handling everywhere =\ )

Done.

https://codereview.chromium.org/2944003003/diff/1/tests/language_strong/super...
File tests/language_strong/super_tearoff_test.dart (right):

https://codereview.chromium.org/2944003003/diff/1/tests/language_strong/super...
tests/language_strong/super_tearoff_test.dart:1: import
'package:expect/expect.dart';
On 2017/06/19 20:24:52, Jennifer Messerly wrote:
> this needs a copyright notice
> 
> alternatively, I think you could easily add this to an existing test. I always
> try and consolidate very simple tests, because compiling+running individual
> language tests adds lots of buildbot and iteration cycle slowness.
> 
> super_from_constructor_test.dart seems like a good place :)
> 

Done.

[Jennifer Messerly, 2017-06-19 20:36:57]

lgtm

[vsm, 2017-06-19 20:40:03]

Description was changed from

==========
Fixes for super tearoff in constructor

Fixes #29932
==========

to

==========
Fixes for super tearoff in constructor

Fixes #29932

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ed8de04f084360d8756d8fd18d32ec11c7882840
==========

[vsm, 2017-06-19 20:40:04]

Committed patchset #5 (id:80001) manually as
ed8de04f084360d8756d8fd18d32ec11c7882840 (presubmit successful).