Fixes for super tearoff in constructor

pkg/dev_compiler/lib/src/compiler/code_generator.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap, HashSet;
 import 'dart:math' show min, max;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 2775 matching lines @@
         return new JS.PropertyAccess(dynType, member);
       }
 
       // For instance members, we add implicit-this.
       // For method tear-offs, we ensure it's a bound method.
       var tearOff = element is MethodElement && !inInvocationContext(node);
       if (tearOff) {
         // To be safe always use the symbolized name when binding on a native
         // class as bind assumes the name will match the name class sigatures
         // which is symbolized for native classes.
+
         var safeName = _emitMemberName(name,
             isStatic: isStatic,
             type: type,
             element: accessor,
             alwaysSymbolizeNative: true);
         return _callHelper('bind(this, #)', safeName);
       }
       return js.call('this.#', member);
     }
 
@@ skipping 2007 matching lines @@
       // subclasses cannot override x.
       jsTarget = annotate(new JS.This(), target);
     }
 
     JS.Expression result;
     if (accessor is MethodElement && !isStatic) {
       // Tear-off methods: explicitly bind it.
       // To be safe always use the symbolized name when binding on a native
       // class as bind assumes the name will match the name class signatures
       // which is symbolized for native classes.
+
       var safeName = _emitMemberName(memberName,
           type: getStaticType(target),
           isStatic: isStatic,
           element: accessor,
           alwaysSymbolizeNative: true);
       if (isSuper) {
-        result =
-            _callHelper('bind(this, #, #.#)', [safeName, jsTarget, safeName]);
+        if (!_superAllowed && jsTarget is JS.Super) {

[Jennifer Messerly, 2017/06/19 20:24:52]

You could refactor this entire code block, replacing with:

if (isSuper) {
  result = _callHelper('bind(this, #, #)',
      [safeName, _emitTargetAccess(jsTarget, name, accessor)]);
} ...


(note: you should not need to pass `safeName` to _emitTargetAccess. The
`safeName` workaround is purely for the `dart.bind` call.)

(note2: frankly, I think `safeName` is not a correct workaround, and someone
added this because they didn't understand how to fix `dart.bind`. Either that or
it dates back to the "angular whitelist hack" that resulted in tons of bogus
extension method handling everywhere =\ )

[vsm, 2017/06/19 20:36:20]

Done.

+          var superName = _getSuperHelper(accessor, safeName)
+            ..sourceInformation = jsTarget.sourceInformation;
+          result = _callHelper('bind(this, #, #)', [safeName, superName]);
+        } else {
+          result =
+              _callHelper('bind(this, #, #.#)', [safeName, jsTarget, safeName]);
+        }
       } else if (_isObjectMemberCall(target, memberName)) {
         result = _callHelper('bind(#, #, #.#)',
             [jsTarget, _propertyName(memberName), _runtimeModule, memberName]);
       } else {
         result = _callHelper('bind(#, #)', [jsTarget, safeName]);
       }
     } else if (_isObjectMemberCall(target, memberName)) {
       result = _callHelper('#(#)', [memberName, jsTarget]);
     } else {
       result = _emitTargetAccess(jsTarget, name, accessor);
@@ skipping 1022 matching lines @@
   if (targetIdentifier.staticElement is! PrefixElement) return false;
   var prefix = targetIdentifier.staticElement as PrefixElement;
 
   // The library the prefix is referring to must come from a deferred import.
   var containingLibrary = resolutionMap
       .elementDeclaredByCompilationUnit(target.root as CompilationUnit)
       .library;
   var imports = containingLibrary.getImportsWithPrefix(prefix);
   return imports.length == 1 && imports[0].isDeferred;
 }