Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2943993002: [v8][wasm] Remove the v8-wasm-asmjs-fuzzer (Closed)

Created:
3 years, 6 months ago by ahaas
Modified:
3 years, 6 months ago
CC:
Clemens Hammacher, bradnelson, chromium-reviews, fuzzing_chromium.org, Michael Starzinger
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8][wasm] Remove the v8-wasm-asmjs-fuzzer This CL removes the v8-wasm-asmjs-fuzzer target function because it violates several assumptions of the production code by now, see the referenced bug. I added Jochen as a reviewer for the changes in DEPS. R=mmoroz@chromium.org, jochen@chromium.org CC=clemensh@chromium.org, mstarzinger@chromium.org, bradnelson@chromium.org BUG=chromium:734550 Review-Url: https://codereview.chromium.org/2943993002 Cr-Commit-Position: refs/heads/master@{#480834} Committed: https://chromium.googlesource.com/chromium/src/+/df281a6ec72a6b641b923c1adb0dda1e8feaed2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
M testing/libfuzzer/fuzzers/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ahaas
3 years, 6 months ago (2017-06-19 12:40:46 UTC) #1
jochen (gone - plz use gerrit)
lgtm
3 years, 6 months ago (2017-06-19 13:13:04 UTC) #4
Clemens Hammacher
Isn't there also C++ code to remove?
3 years, 6 months ago (2017-06-19 13:14:21 UTC) #5
ahaas
On 2017/06/19 at 13:14:21, clemensh wrote: > Isn't there also C++ code to remove? The ...
3 years, 6 months ago (2017-06-19 14:48:25 UTC) #6
mmoroz
It's sad to lose fuzzers, but LGTM
3 years, 6 months ago (2017-06-19 18:35:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943993002/1
3 years, 6 months ago (2017-06-20 13:34:38 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 15:52:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df281a6ec72a6b641b923c1adb0d...

Powered by Google App Engine
This is Rietveld 408576698