Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: addressed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index 1c3e5738b25e16ab1e18c94ffb99aadfb2d5ec81..c34fad512795a035ff7ae2e69f3c43046a88a13b 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -63,6 +63,7 @@ class FrameResourceCoordinator;
class FrameSelection;
class InputMethodController;
class CoreProbeSink;
+class HTMLMediaElement;
class InterfaceProvider;
class InterfaceRegistry;
class IntPoint;
@@ -129,6 +130,11 @@ class CORE_EXPORT LocalFrame final : public Frame,
void DetachChildren();
void DocumentAttached();
+ void ShowDownloadMediaInProductHelp(HTMLMediaElement&);
+ bool IsDownloadMediaInProductHelpVisibleForElement(HTMLMediaElement&);
+ void LayoutUpdated();
+ void NotifyInProductHelpDismissed();
+
Frame* FindFrameForNavigation(const AtomicString& name,
LocalFrame& active_frame);
@@ -327,6 +333,10 @@ class CORE_EXPORT LocalFrame final : public Frame,
IntRect remote_viewport_intersection_;
Member<FrameResourceCoordinator> frame_resource_coordinator_;
+
+ // Restricts showing the download media in-product help to once per frame.
+ bool media_in_product_help_shown_for_frame_ = false;
+ WeakMember<HTMLMediaElement> element_with_active_in_product_help_;
};
inline FrameLoader& LocalFrame::Loader() const {

Powered by Google App Engine
This is Rietveld 408576698