components/feature_engagement_tracker/public/feature_constants.h - Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feature_engagement_tracker/public/feature_constants.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)

Patch Set: addressed comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/feature_engagement_tracker/public/feature_constants.h

diff --git a/components/feature_engagement_tracker/public/feature_constants.h b/components/feature_engagement_tracker/public/feature_constants.h

index b5250b4e8db7ec3b8308e328c7fada3a737558eb..0b009d59e0f6d62c6bf9aa52034cb862ffbdb2b9 100644

--- a/components/feature_engagement_tracker/public/feature_constants.h

+++ b/components/feature_engagement_tracker/public/feature_constants.h

@@ -24,6 +24,7 @@ extern const base::Feature kIPHDataSaverPreviewFeature;

extern const base::Feature kIPHDataSaverDetailFeature;

extern const base::Feature kIPHDownloadPageFeature;

extern const base::Feature kIPHDownloadHomeFeature;

+extern const base::Feature kIPHMediaDownloadFeature;

nyquist 2017/06/29 02:10:24 Could you add the metrics for this new feature as

Khushal 2017/07/07 04:18:14 Done.

#endif // OS_ANDROID

} // namespace feature_engagement_tracker