content/renderer/render_view_impl.cc - Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)

Patch Set: addressed comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 9aa953a0ee82829276c7f222a84244e65504a0e5..721c36152d07abffefea249ad622b62adefefdd1 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -985,6 +985,8 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,

settings->SetEmbeddedMediaExperienceEnabled(

prefs.embedded_media_experience_enabled);

settings->SetPagePopupsSuppressed(prefs.page_popups_suppressed);

+ settings->SetMediaDownloadInProductHelpEnabled(

+ prefs.enable_media_in_product_help);

settings->SetDoNotUpdateSelectionOnMutatingSelectionRange(

prefs.do_not_update_selection_on_mutating_selection_range);

#endif // defined(OS_ANDROID)