Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: components/feature_engagement_tracker/public/feature_constants.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: addressed comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_CONSTANTS_H_ 5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_CONSTANTS_H_
6 #define COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_CONSTANTS_H_ 6 #define COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_CONSTANTS_H_
7 7
8 #include "base/feature_list.h" 8 #include "base/feature_list.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 10
11 namespace feature_engagement_tracker { 11 namespace feature_engagement_tracker {
12 12
13 // A feature for enabling a demonstration mode for In-Product Help. 13 // A feature for enabling a demonstration mode for In-Product Help.
14 extern const base::Feature kIPHDemoMode; 14 extern const base::Feature kIPHDemoMode;
15 15
16 // A feature to ensure all arrays can contain at least one feature. 16 // A feature to ensure all arrays can contain at least one feature.
17 extern const base::Feature kIPHDummyFeature; 17 extern const base::Feature kIPHDummyFeature;
18 18
19 // All the features declared for Android below that are also used in Java, 19 // All the features declared for Android below that are also used in Java,
20 // should also be declared in: 20 // should also be declared in:
21 // org.chromium.components.feature_engagement_tracker.FeatureConstants. 21 // org.chromium.components.feature_engagement_tracker.FeatureConstants.
22 #if defined(OS_ANDROID) 22 #if defined(OS_ANDROID)
23 extern const base::Feature kIPHDataSaverPreviewFeature; 23 extern const base::Feature kIPHDataSaverPreviewFeature;
24 extern const base::Feature kIPHDataSaverDetailFeature; 24 extern const base::Feature kIPHDataSaverDetailFeature;
25 extern const base::Feature kIPHDownloadPageFeature; 25 extern const base::Feature kIPHDownloadPageFeature;
26 extern const base::Feature kIPHDownloadHomeFeature; 26 extern const base::Feature kIPHDownloadHomeFeature;
27 extern const base::Feature kIPHMediaDownloadFeature;
nyquist 2017/06/29 02:10:24 Could you add the metrics for this new feature as
Khushal 2017/07/07 04:18:14 Done.
27 #endif // OS_ANDROID 28 #endif // OS_ANDROID
28 29
29 } // namespace feature_engagement_tracker 30 } // namespace feature_engagement_tracker
30 31
31 #endif // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_CONSTANTS_H_ 32 #endif // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_CONSTANTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698