[LayoutNG] Implement CSS 'text-indent' property

third_party/WebKit/Source/core/style/ComputedStyle.cpp

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index dc9453b0c6038c467b69fa87e53dba0cf0e83b7c..a82afadb42f79326fe090bb63dc0033b38047e1d 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -1296,6 +1296,14 @@ ETextAlign ComputedStyle::GetTextAlign(bool is_last_line) const {
   return GetTextAlign();
 }
 
+bool ComputedStyle::ShouldUseTextIndent(bool is_first_line,
+                                        bool is_after_forced_break) const {
+  bool should_use =
+      is_first_line || (is_after_forced_break &&
+                        GetTextIndentLine() != TextIndentLine::kFirstLine);
+  return TextIndentType() == TextIndentType::kNormal ? should_use : !should_use;

[Nico, 2017/09/15 19:33:57]

Is this meant to call GetTextIndentType()? As-is, this default-constructs an
instance of the TextIndentType() enum (which is always kNormal), so this always
returns should_use.

Maybe this is missing some test coverage?

(Found by this warning which I'm currently evaluating:

../../third_party/WebKit/Source/core/style/ComputedStyle.cpp(1259,70):  error:
code will never be executed [-Werror,-Wunreachable-code]
  return TextIndentType() == TextIndentType::kNormal ? should_use : !should_use;
                                                                     ^~~~~~~~~~
)

[kojii, 2017/09/16 05:25:21]

Thanks, you're right, I'll send a fix.
We do cover, but I was implementing CSS2 and this is in CSS3, and CSS3 tests are
still failing for other reasons.

Still it was helpful to find this out, thank you!

+}
+
 const AtomicString& ComputedStyle::TextEmphasisMarkString() const {
   switch (GetTextEmphasisMark()) {
     case TextEmphasisMark::kNone: