[LayoutNG] Implement CSS 'text-indent' property

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 1278 matching lines @@
     case ETextAlignLast::kAuto:
       ETextAlign text_align = GetTextAlign();
       if (text_align == ETextAlign::kJustify)
         return ETextAlign::kStart;
       return text_align;
   }
   NOTREACHED();
   return GetTextAlign();
 }
 
+bool ComputedStyle::ShouldUseTextIndent(bool is_first_line,
+                                        bool is_after_forced_break) const {
+  bool should_use =
+      is_first_line || (is_after_forced_break &&
+                        GetTextIndentLine() != TextIndentLine::kFirstLine);
+  return TextIndentType() == TextIndentType::kNormal ? should_use : !should_use;

[Nico, 2017/09/15 19:33:57]

Is this meant to call GetTextIndentType()? As-is, this default-constructs an
instance of the TextIndentType() enum (which is always kNormal), so this always
returns should_use.

Maybe this is missing some test coverage?

(Found by this warning which I'm currently evaluating:

../../third_party/WebKit/Source/core/style/ComputedStyle.cpp(1259,70):  error:
code will never be executed [-Werror,-Wunreachable-code]
  return TextIndentType() == TextIndentType::kNormal ? should_use : !should_use;
                                                                     ^~~~~~~~~~
)

[kojii, 2017/09/16 05:25:21]

Thanks, you're right, I'll send a fix.
We do cover, but I was implementing CSS2 and this is in CSS3, and CSS3 tests are
still failing for other reasons.

Still it was helpful to find this out, thank you!

+}
+
 const AtomicString& ComputedStyle::TextEmphasisMarkString() const {
   switch (GetTextEmphasisMark()) {
     case TextEmphasisMark::kNone:
       return g_null_atom;
     case TextEmphasisMark::kCustom:
       return TextEmphasisCustomMark();
     case TextEmphasisMark::kDot: {
       DEFINE_STATIC_LOCAL(AtomicString, filled_dot_string,
                           (&kBulletCharacter, 1));
       DEFINE_STATIC_LOCAL(AtomicString, open_dot_string,
@@ skipping 900 matching lines @@
     if (value < 0)
       fvalue -= 0.5f;
     else
       fvalue += 0.5f;
   }
 
   return RoundForImpreciseConversion<int>(fvalue / zoom_factor);
 }
 
 }  // namespace blink