keyboard::SendKeyEvent() doesn't need to send events to InputMethod directly.

keyboard::SendKeyEvent() doesn't need to send events to InputMethod directly.

WindowEventDispatcher does the dispatch to InputMethod.

BUG=NONE

Review-Url: https://codereview.chromium.org/2943973003
Cr-Commit-Position: refs/heads/master@{#480977}
Committed: https://chromium.googlesource.com/chromium/src/+/138a53f2087b9ea13592bfed768805e140c700ca

[Hadi, 2017-06-19 20:42:18]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 20:42:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hadi, 2017-06-19 20:44:08]

moshayedi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Hadi, 2017-06-19 20:44:09]

PTAL. This was detected while working on the returning dispatch details from
InputMethod::DispatchKeyEvent() CL.

[commit-bot: I haz the power, 2017-06-19 21:54:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 21:54:59]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-06-20 12:56:10]

https://codereview.chromium.org/2943973003/diff/1/ui/keyboard/keyboard_util.cc
File ui/keyboard/keyboard_util.cc (right):

https://codereview.chromium.org/2943973003/diff/1/ui/keyboard/keyboard_util.c...
ui/keyboard/keyboard_util.cc:353: CHECK(!details.dispatcher_destroyed);
Just to confirm: is there a difference to whether the pre/post target event
handlers are triggered because of this change?

[Hadi, 2017-06-20 14:41:11]

https://codereview.chromium.org/2943973003/diff/1/ui/keyboard/keyboard_util.cc
File ui/keyboard/keyboard_util.cc (right):

https://codereview.chromium.org/2943973003/diff/1/ui/keyboard/keyboard_util.c...
ui/keyboard/keyboard_util.cc:353: CHECK(!details.dispatcher_destroyed);
On 2017/06/20 12:56:10, sadrul wrote:
> Just to confirm: is there a difference to whether the pre/post target event
> handlers are triggered because of this change?

WindowEventDispatcher sends the key event to InputMethod before trying
pre/post-target event handlers which happens later at
EventDispatcher::ProcessEvent(), so I think the behavior for this doesn't change
because of this CL.

[sadrul, 2017-06-20 20:45:18]

lgtm

[Hadi, 2017-06-20 20:48:47]

The CQ bit was checked by moshayedi@chromium.org

[commit-bot: I haz the power, 2017-06-20 20:49:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 21:58:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497991727178820, "parent_rev":
"d2c3c29e263ebd0382593b2d0f9de17f471a0735", "commit_rev":
"3c3f2990bbc595c0567785bbfb980c82b1ec0b5f"}

[commit-bot: I haz the power, 2017-06-20 21:58:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497991727178820, "parent_rev":
"f7abd4c15fe6096a0a06a06fa5d42dfd6b791968", "commit_rev":
"138a53f2087b9ea13592bfed768805e140c700ca"}

[commit-bot: I haz the power, 2017-06-20 21:58:35]

Description was changed from

==========
keyboard::SendKeyEvent() doesn't need to send events to InputMethod directly.

WindowEventDispatcher does the dispatch to InputMethod.

BUG=NONE
==========

to

==========
keyboard::SendKeyEvent() doesn't need to send events to InputMethod directly.

WindowEventDispatcher does the dispatch to InputMethod.

BUG=NONE

Review-Url: https://codereview.chromium.org/2943973003
Cr-Commit-Position: refs/heads/master@{#480977}
Committed:
https://chromium.googlesource.com/chromium/src/+/138a53f2087b9ea13592bfed7688...
==========

[commit-bot: I haz the power, 2017-06-20 21:58:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/138a53f2087b9ea13592bfed7688...