Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2943953002:
Don't disable MemoryPressureListener when MemoryCoordinator is enabled (Closed)
DescriptionDon't disable MemoryPressureListener when MemoryCoordinator is enabled
Memory coordinator is going to focus on how/when to request tab
discarding and won't replace existing MemoryPressureListeners except for
TabManager. We shouldn't disable MemoryPressureListeners.
BUG=696844
Review-Url: https://codereview.chromium.org/2943953002
Cr-Commit-Position: refs/heads/master@{#481674}
Committed: https://chromium.googlesource.com/chromium/src/+/85241f184bc209cc43e1552b2113806e9f3321a7
Patch Set 1 : fix condition #Patch Set 2 : fix include #Patch Set 3 : Fix namespace #
Total comments: 2
Patch Set 4 : Fix comment #
Messages
Total messages: 38 (29 generated)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
bashi@chromium.org changed reviewers: + chrisha@chromium.org, haraken@chromium.org
PTAL after https://codereview.chromium.org/2943283002/
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fmeawad@chromium.org changed reviewers: + fmeawad@chromium.org
drive by nit https://codereview.chromium.org/2943953002/diff/80001/chrome/browser/resource... File chrome/browser/resource_coordinator/tab_manager.cc (right): https://codereview.chromium.org/2943953002/diff/80001/chrome/browser/resource... chrome/browser/resource_coordinator/tab_manager.cc:171: // it asks TabManager to tab discarding. nit: to "do" tab discarding?
lgtm
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2943953002/diff/80001/chrome/browser/resource... File chrome/browser/resource_coordinator/tab_manager.cc (right): https://codereview.chromium.org/2943953002/diff/80001/chrome/browser/resource... chrome/browser/resource_coordinator/tab_manager.cc:171: // it asks TabManager to tab discarding. On 2017/06/19 19:54:59, fmeawad wrote: > nit: to "do" tab discarding? Done. Thanks!
bashi@chromium.org changed reviewers: + jam@chromium.org
jam@: could you review content/browser/browser_main_loop.cc ?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bashi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, chrisha@chromium.org Link to the patchset: https://codereview.chromium.org/2943953002/#ps100001 (title: "Fix comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498167713484690,
"parent_rev": "e92354177987b98fdbdd0a44f069eb209d770adc", "commit_rev":
"85241f184bc209cc43e1552b2113806e9f3321a7"}
Message was sent while issue was closed.
Description was changed from ========== Don't disable MemoryPressureListener when MemoryCoordinator is enabled Memory coordinator is going to focus on how/when to request tab discarding and won't replace existing MemoryPressureListeners except for TabManager. We shouldn't disable MemoryPressureListeners. BUG=696844 ========== to ========== Don't disable MemoryPressureListener when MemoryCoordinator is enabled Memory coordinator is going to focus on how/when to request tab discarding and won't replace existing MemoryPressureListeners except for TabManager. We shouldn't disable MemoryPressureListeners. BUG=696844 Review-Url: https://codereview.chromium.org/2943953002 Cr-Commit-Position: refs/heads/master@{#481674} Committed: https://chromium.googlesource.com/chromium/src/+/85241f184bc209cc43e1552b2113... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as https://chromium.googlesource.com/chromium/src/+/85241f184bc209cc43e1552b2113... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
