Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 294393008: [Mirror Android] Temporarily remove the Mirror flag. (Closed)

Created:
6 years, 7 months ago by aruslan
Modified:
6 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Visibility:
Public.

Description

[Mirror Android] Temporarily remove the Mirror flag. Once in trunk this needs to be picked up to M36 beta branch. Once picked up by the branch, this needs to be reverted on trunk. BUG=378025 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
aruslan
Ted, PTAL thanks!
6 years, 7 months ago (2014-05-27 22:50:43 UTC) #1
Ted C
lgtm
6 years, 7 months ago (2014-05-27 22:59:05 UTC) #2
aruslan
The CQ bit was checked by aruslan@chromium.org
6 years, 7 months ago (2014-05-27 22:59:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/294393008/1
6 years, 7 months ago (2014-05-27 23:00:01 UTC) #4
commit-bot: I haz the power
Change committed as 273067
6 years, 7 months ago (2014-05-27 23:15:50 UTC) #5
aruslan
6 years, 6 months ago (2014-05-28 17:46:31 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/294393013/ by aruslan@chromium.org.

The reason for reverting is: The removal of the flag landed to M36 as
https://src.chromium.org/viewvc/chrome?revision=273283&view=revision

Reverting the change (== introducing the Android Mirror flag back) on the
trunk..

Powered by Google App Engine
This is Rietveld 408576698