Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: ui/gfx/render_text_mac.mm

Issue 2943823002: Remove gfx::DIAGONAL_STRIKE and supporting code. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/render_text_mac.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_mac.mm
diff --git a/ui/gfx/render_text_mac.mm b/ui/gfx/render_text_mac.mm
index eafd25ad3d68de72db99c2944ef851698cbbede5..67058173093e471a296da0ff75b60618149e197c 100644
--- a/ui/gfx/render_text_mac.mm
+++ b/ui/gfx/render_text_mac.mm
@@ -260,10 +260,8 @@ void RenderTextMac::DrawVisualText(internal::SkiaTextRenderer* renderer) {
renderer->DrawPosText(&run.glyph_positions[0], &run.glyphs[0],
run.glyphs.size());
renderer->DrawDecorations(run.origin.x(), run.origin.y(), run.width,
- run.underline, run.strike, run.diagonal_strike);
+ run.underline, run.strike);
}
-
- renderer->EndDiagonalStrike();
}
RenderTextMac::TextRun::TextRun()
@@ -272,8 +270,7 @@ RenderTextMac::TextRun::TextRun()
width(0),
foreground(SK_ColorBLACK),
underline(false),
- strike(false),
- diagonal_strike(false) {}
+ strike(false) {}
RenderTextMac::TextRun::TextRun(TextRun&& other) = default;
@@ -444,7 +441,7 @@ void RenderTextMac::ComputeRuns() {
}
// TODO(asvitkine): Style boundaries are not necessarily per-run. Handle
- // this better. Also, support strike and diagonal_strike.
+ // this better. Also, support strike.
CFDictionaryRef attributes = CTRunGetAttributes(ct_run);
CTFontRef ct_font = base::mac::GetValueFromDictionary<CTFontRef>(
attributes, kCTFontAttributeName);
« no previous file with comments | « ui/gfx/render_text_mac.h ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698