Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2943713002:
fuchsia: Make sdch build. (Closed)
Descriptionfuchsia: Make sdch build.
Linux's config.h seems close enough, so use that.
BUG=731302
Review-Url: https://codereview.chromium.org/2943713002
Cr-Commit-Position: refs/heads/master@{#480131}
Committed: https://chromium.googlesource.com/chromium/src/+/8f9ff13dfa8191f7c69d91dad4f3cbf2d5b7b249
Patch Set 1 #
Messages
Total messages: 23 (15 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + scottmg@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm 731302 might be a better BUG=
Description was changed from ========== fuchsia: Make sdch build. Linux's config.h seems close enough, so use that. BUG=731280 ========== to ========== fuchsia: Make sdch build. Linux's config.h seems close enough, so use that. BUG=731302 ==========
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
thakis@chromium.org changed reviewers: + ellyjones@chromium.org
+ellyjones for sdch owners
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497642376512260, "parent_rev":
"f075890fd7d9a80f78615febda8c31f0bdbd02b3", "commit_rev":
"8f9ff13dfa8191f7c69d91dad4f3cbf2d5b7b249"}
Message was sent while issue was closed.
Description was changed from ========== fuchsia: Make sdch build. Linux's config.h seems close enough, so use that. BUG=731302 ========== to ========== fuchsia: Make sdch build. Linux's config.h seems close enough, so use that. BUG=731302 Review-Url: https://codereview.chromium.org/2943713002 Cr-Commit-Position: refs/heads/master@{#480131} Committed: https://chromium.googlesource.com/chromium/src/+/8f9ff13dfa8191f7c69d91dad4f3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8f9ff13dfa8191f7c69d91dad4f3... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
