Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2943703002: Use ContainsValue() instead of std::find() in net/ (Closed)

Created:
3 years, 6 months ago by Tripta
Modified:
3 years, 6 months ago
Reviewers:
asanka
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, eroman, mmenke, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContainsValue() instead of std::find() in net/ BUG=561800 Review-Url: https://codereview.chromium.org/2943703002 Cr-Commit-Position: refs/heads/master@{#480353} Committed: https://chromium.googlesource.com/chromium/src/+/dda720249a41f271c31c85ab47cd64ed35a2b242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -57 lines) Patch
M net/base/mime_util_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/base/network_throttle_manager_impl.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M net/cert/x509_certificate.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_bytes.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/cookies/cookie_monster.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/dns/host_resolver_impl_unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M net/extras/sqlite/sqlite_channel_id_store.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M net/http/http_security_headers.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/http/http_security_headers_unittest.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M net/http/transport_security_state.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/log/net_log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_tag.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Tripta
Hi Asanka, Please review code changes for below files: net/base/mime_util_unittest.cc net/base/network_throttle_manager_impl.cc net/cert/x509_certificate.cc net/cert/x509_certificate_bytes.cc net/cookies/cookie_monster.cc net/dns/host_resolver_impl_unittest.cc ...
3 years, 6 months ago (2017-06-16 13:01:08 UTC) #3
asanka
lgtm
3 years, 6 months ago (2017-06-16 17:34:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943703002/1
3 years, 6 months ago (2017-06-18 12:49:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/481724)
3 years, 6 months ago (2017-06-18 13:50:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943703002/1
3 years, 6 months ago (2017-06-19 03:26:05 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 05:16:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dda720249a41f271c31c85ab47cd...

Powered by Google App Engine
This is Rietveld 408576698