Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2943673002: Allow using cgdb with adb_gdb script. (Closed)

Created:
3 years, 6 months ago by sakal-chromium
Modified:
3 years, 6 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow using cgdb with adb_gdb script. BUG=None Review-Url: https://codereview.chromium.org/2943673002 Cr-Commit-Position: refs/heads/master@{#480438} Committed: https://chromium.googlesource.com/chromium/src/+/a4dfc3384d314117cbf013be54f689cf64be9f8b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M build/android/adb_gdb View 1 4 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sakal-chromium
PTAL
3 years, 6 months ago (2017-06-16 10:55:43 UTC) #3
jbudorick
lgtm w/ nit https://codereview.chromium.org/2943673002/diff/1/build/android/adb_gdb File build/android/adb_gdb (right): https://codereview.chromium.org/2943673002/diff/1/build/android/adb_gdb#newcode213 build/android/adb_gdb:213: --cgdb*) nit: should this be --cgdb=* ...
3 years, 6 months ago (2017-06-19 13:11:39 UTC) #4
sakal-chromium
https://codereview.chromium.org/2943673002/diff/1/build/android/adb_gdb File build/android/adb_gdb (right): https://codereview.chromium.org/2943673002/diff/1/build/android/adb_gdb#newcode213 build/android/adb_gdb:213: --cgdb*) On 2017/06/19 13:11:39, jbudorick wrote: > nit: should ...
3 years, 6 months ago (2017-06-19 14:50:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943673002/20001
3 years, 6 months ago (2017-06-19 14:50:47 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 15:04:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4dfc3384d314117cbf013be54f6...

Powered by Google App Engine
This is Rietveld 408576698