Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2943623002: Reduce indentation in ComputeInlineBoxPositionTemplate() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce indentation in ComputeInlineBoxPositionTemplate() This patch reduces indentation in |ComputeInlineBoxPositionTemplate()| by switching if-condition to move large then-clause out of if-statement for improving of readability. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2943623002 Cr-Commit-Position: refs/heads/master@{#480337} Committed: https://chromium.googlesource.com/chromium/src/+/38c57515aad29dfce4bd77c885ba937c5b93371b

Patch Set 1 : 2017-06-16T14:52:49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +34 lines, -36 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-16 08:18:23 UTC) #7
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-16 18:17:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943623002/1
3 years, 6 months ago (2017-06-17 03:02:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/466759)
3 years, 6 months ago (2017-06-17 03:05:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943623002/1
3 years, 6 months ago (2017-06-19 01:58:29 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 03:29:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/38c57515aad29dfce4bd77c885ba...

Powered by Google App Engine
This is Rietveld 408576698