Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 2943603002: Remove MemoryCondition::WARNING (Closed)

Created:
3 years, 6 months ago by bashi
Modified:
3 years, 6 months ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, chrome-grc-reviews+memory_chromium.org, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MemoryCondition::WARNING It's not clear that having WARNING condition helps us to build a reasonable policy to handle memory pressure. Just use a binary (NORMAL and CRITICAL) until we really need it. This CL also simplifies the heuristic to estimate memory pressure to reduce complexity. BUG=696844 Review-Url: https://codereview.chromium.org/2943603002 Cr-Commit-Position: refs/heads/master@{#480336} Committed: https://chromium.googlesource.com/chromium/src/+/1960d03cec25ebdf6d8d14a06e2eeebf19debcc2

Patch Set 1 #

Patch Set 2 : Fix android #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -340 lines) Patch
M content/browser/memory/memory_condition_observer.h View 2 chunks +3 lines, -35 lines 0 comments Download
M content/browser/memory/memory_condition_observer.cc View 4 chunks +12 lines, -104 lines 0 comments Download
M content/browser/memory/memory_coordinator_default_policy.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/memory/memory_coordinator_default_policy.cc View 4 chunks +5 lines, -31 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 1 2 10 chunks +19 lines, -154 lines 0 comments Download
M content/browser/memory/memory_monitor_android.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (18 generated)
bashi
PTAL
3 years, 6 months ago (2017-06-16 02:21:56 UTC) #5
haraken
LGTM
3 years, 6 months ago (2017-06-16 02:23:10 UTC) #6
chrisha
lgtm
3 years, 6 months ago (2017-06-16 17:26:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943603002/40001
3 years, 6 months ago (2017-06-19 03:22:02 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 03:26:13 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1960d03cec25ebdf6d8d14a06e2e...

Powered by Google App Engine
This is Rietveld 408576698