Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2943493002: [WebView] Add WebView platform to Finch's study.proto (Closed)

Created:
3 years, 6 months ago by yiyuny
Modified:
3 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebView platform to Finch's study.proto BUG=732996 Review-Url: https://codereview.chromium.org/2943493002 Cr-Commit-Position: refs/heads/master@{#479863} Committed: https://chromium.googlesource.com/chromium/src/+/db6d7fe9267ec2297918e2589558f0a46d1f7039

Patch Set 1 #

Patch Set 2 : [WebView] Update unittest CheckStudyPlatform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M components/variations/proto/study.proto View 1 chunk +7 lines, -6 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yiyuny
On 2017/06/15 17:39:29, yiyuny wrote: > mailto:yiyuny@google.com changed reviewers: > + mailto:asvitkine@chromium.org PTAL
3 years, 6 months ago (2017-06-15 17:40:18 UTC) #3
Alexei Svitkine (slow)
lgtm
3 years, 6 months ago (2017-06-15 17:43:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943493002/1
3 years, 6 months ago (2017-06-15 17:50:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/118227)
3 years, 6 months ago (2017-06-15 18:03:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943493002/20001
3 years, 6 months ago (2017-06-15 20:53:49 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 22:21:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/db6d7fe9267ec2297918e2589558...

Powered by Google App Engine
This is Rietveld 408576698