[Payments] Log multiple events in the journey logger.

[Payments] Log multiple events in the journey logger.

These events were previously not logged on Desktop.
-> Shown
-> PayClicked
-> ReceivedInstrumentDetails

BUG=734129
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2943433004
Cr-Commit-Position: refs/heads/master@{#480147}
Committed: https://chromium.googlesource.com/chromium/src/+/57c8c86a2c893718deccf721253858e14f365891

[Mathieu, 2017-06-16 17:49:03]

mathp@chromium.org changed reviewers:
+ sebsg@chromium.org

[Mathieu, 2017-06-16 17:49:03]

Seb, PTAL

[sebsg, 2017-06-16 18:26:48]

lgtm % comment

https://codereview.chromium.org/2943433004/diff/1/chrome/browser/ui/views/pay...
File
chrome/browser/ui/views/payments/payment_request_completion_status_metrics_browsertest.cc
(right):

https://codereview.chromium.org/2943433004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_completion_status_metrics_browsertest.cc:82:
histogram_tester.ExpectUniqueSample("PaymentRequest.CheckoutFunnel.Shown", 1,
Initiated too?

[Mathieu, 2017-06-16 19:03:01]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-06-16 19:03:01]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2943433004/#ps20001
(title: "addressed comment")

[Mathieu, 2017-06-16 19:03:14]

submitting

https://codereview.chromium.org/2943433004/diff/1/chrome/browser/ui/views/pay...
File
chrome/browser/ui/views/payments/payment_request_completion_status_metrics_browsertest.cc
(right):

https://codereview.chromium.org/2943433004/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_completion_status_metrics_browsertest.cc:82:
histogram_tester.ExpectUniqueSample("PaymentRequest.CheckoutFunnel.Shown", 1,
On 2017/06/16 18:26:48, sebsg wrote:
> Initiated too?

Done.

[commit-bot: I haz the power, 2017-06-16 19:03:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 20:15:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497639781441830,
"parent_rev": "e10aedf65eacdd8b5f31355318a29cdf40e886a6", "commit_rev":
"57c8c86a2c893718deccf721253858e14f365891"}

[commit-bot: I haz the power, 2017-06-16 20:16:03]

Description was changed from

==========
[Payments] Log multiple events in the journey logger.

These events were previously not logged on Desktop.
-> Shown
-> PayClicked
-> ReceivedInstrumentDetails

BUG=734129
TEST=browser_tests
==========

to

==========
[Payments] Log multiple events in the journey logger.

These events were previously not logged on Desktop.
-> Shown
-> PayClicked
-> ReceivedInstrumentDetails

BUG=734129
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2943433004
Cr-Commit-Position: refs/heads/master@{#480147}
Committed:
https://chromium.googlesource.com/chromium/src/+/57c8c86a2c893718deccf7212538...
==========

[commit-bot: I haz the power, 2017-06-16 20:16:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/57c8c86a2c893718deccf7212538...