Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2943433002: Revert of Remove FORMAT_RGB from gfx::PngCodec (Closed)

Created:
3 years, 6 months ago by Owen Lin
Modified:
3 years, 6 months ago
CC:
liyuqian, chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove FORMAT_RGB from gfx::PngCodec (patchset #3 id:40001 of https://codereview.chromium.org/2927893002/ ) Reason for revert: Break the VDA unittest, see http://crbug.com/733522. Original issue's description: > Remove FORMAT_RGB from gfx::PngCodec > > This is only used in test code. > > BUG=724616 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2927893002 > Cr-Commit-Position: refs/heads/master@{#479124} > Committed: https://chromium.googlesource.com/chromium/src/+/a9cbb594d5b28bdc51b7b505d201930221ddbe8a TBR=msarett@chromium.org,scroggo@chromium.org,dcheng@chromium.org,sandersd@chromium.org,msarett@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724616 Review-Url: https://codereview.chromium.org/2943433002 Cr-Commit-Position: refs/heads/master@{#479669} Committed: https://chromium.googlesource.com/chromium/src/+/61479a854982e3749c4322a4c5dede07b713a163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -37 lines) Patch
M media/gpu/rendering_helper.h View 1 chunk +5 lines, -3 lines 0 comments Download
M media/gpu/rendering_helper.cc View 2 chunks +18 lines, -3 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M ui/gfx/codec/png_codec.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/codec/png_codec.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M ui/gfx/codec/png_codec_unittest.cc View 8 chunks +241 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Owen Lin
Created Revert of Remove FORMAT_RGB from gfx::PngCodec
3 years, 6 months ago (2017-06-15 07:16:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943433002/1
3 years, 6 months ago (2017-06-15 07:17:13 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/450172)
3 years, 6 months ago (2017-06-15 07:57:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943433002/1
3 years, 6 months ago (2017-06-15 11:00:26 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 11:57:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61479a854982e3749c4322a4c5de...

Powered by Google App Engine
This is Rietveld 408576698