Source/core/editing/InsertListCommand.cpp - Issue 294343007: Oilpan: transition types for remaining Node hierarchy object occurrences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertListCommand.cpp

Issue 294343007: Oilpan: transition types for remaining Node hierarchy object occurrences. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/InsertListCommand.cpp

diff --git a/Source/core/editing/InsertListCommand.cpp b/Source/core/editing/InsertListCommand.cpp

index 5e0cb25002b78ba852d57a348d82d152eae98055..bd52c559cb5e31360b9bcffd2a60f02136272534 100644

--- a/Source/core/editing/InsertListCommand.cpp

+++ b/Source/core/editing/InsertListCommand.cpp

@@ -135,7 +135,7 @@ void InsertListCommand::doApply()

VisiblePosition startOfLastParagraph = startOfParagraph(endOfSelection, CanSkipOverEditingBoundary);

if (startOfParagraph(startOfSelection, CanSkipOverEditingBoundary) != startOfLastParagraph) {

- RefPtr<ContainerNode> scope;

+ RefPtrWillBeRawPtr<ContainerNode> scope = nullptr;

int indexForEndOfSelection = indexForVisiblePosition(endOfSelection, scope);

bool forceCreateList = !selectionHasListOfType(selection, listTag);

« no previous file with comments | « Source/core/editing/ApplyBlockElementCommand.cpp ('k') | Source/core/editing/htmlediting.h » ('j') | Source/core/editing/htmlediting.cpp » ('J')