Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: Source/core/editing/htmlediting.cpp

Issue 294343007: Oilpan: transition types for remaining Node hierarchy object occurrences. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/htmlediting.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/htmlediting.cpp
diff --git a/Source/core/editing/htmlediting.cpp b/Source/core/editing/htmlediting.cpp
index bcac291ce832502cab92e51c9db6c1a84d1b1bfd..6c7b309faf972a3ab3f1ef79fcc17fbb298bb8aa 100644
--- a/Source/core/editing/htmlediting.cpp
+++ b/Source/core/editing/htmlediting.cpp
@@ -837,9 +837,9 @@ Node* tabSpanNode(const Node* node)
return isTabSpanTextNode(node) ? node->parentNode() : 0;
}
-PassRefPtrWillBeRawPtr<Element> createTabSpanElement(Document& document, PassRefPtr<Node> prpTabTextNode)
+PassRefPtrWillBeRawPtr<Element> createTabSpanElement(Document& document, PassRefPtrWillBeRawPtr<Node> prpTabTextNode)
{
- RefPtr<Node> tabTextNode = prpTabTextNode;
+ RefPtrWillBeRawPtr<Node> tabTextNode = prpTabTextNode;
// Make the span to hold the tab.
RefPtrWillBeRawPtr<Element> spanElement = document.createElement(spanTag, false);
@@ -862,7 +862,7 @@ PassRefPtrWillBeRawPtr<Element> createTabSpanElement(Document& document, const S
PassRefPtrWillBeRawPtr<Element> createTabSpanElement(Document& document)
{
- return createTabSpanElement(document, PassRefPtr<Node>());
+ return createTabSpanElement(document, PassRefPtrWillBeRawPtr<Node>(nullptr));
haraken 2014/05/25 18:08:46 Doesn't just 'nullptr' work?
sof 2014/05/25 18:11:23 That's ambiguous -- there's also createTabSpanElem
}
bool isNodeRendered(const Node *node)
@@ -1001,7 +1001,7 @@ VisibleSelection selectionForParagraphIteration(const VisibleSelection& original
// opertion is unreliable. TextIterator's TextIteratorEmitsCharactersBetweenAllVisiblePositions mode needs to be fixed,
// or these functions need to be changed to iterate using actual VisiblePositions.
// FIXME: Deploy these functions everywhere that TextIterators are used to convert between VisiblePositions and indices.
-int indexForVisiblePosition(const VisiblePosition& visiblePosition, RefPtr<ContainerNode>& scope)
+int indexForVisiblePosition(const VisiblePosition& visiblePosition, RefPtrWillBeRawPtr<ContainerNode>& scope)
{
if (visiblePosition.isNull())
return 0;
« no previous file with comments | « Source/core/editing/htmlediting.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698