Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294343007: Oilpan: transition types for remaining Node hierarchy object occurrences. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: transition types for remaining Node hierarchy object occurrences. R=haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174776

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/editing/ApplyBlockElementCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 3 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 7 months ago (2014-05-25 16:30:56 UTC) #1
haraken
LGTM https://codereview.chromium.org/294343007/diff/1/Source/core/editing/htmlediting.cpp File Source/core/editing/htmlediting.cpp (right): https://codereview.chromium.org/294343007/diff/1/Source/core/editing/htmlediting.cpp#newcode865 Source/core/editing/htmlediting.cpp:865: return createTabSpanElement(document, PassRefPtrWillBeRawPtr<Node>(nullptr)); Doesn't just 'nullptr' work?
6 years, 7 months ago (2014-05-25 18:08:45 UTC) #2
sof
https://codereview.chromium.org/294343007/diff/1/Source/core/editing/htmlediting.cpp File Source/core/editing/htmlediting.cpp (right): https://codereview.chromium.org/294343007/diff/1/Source/core/editing/htmlediting.cpp#newcode865 Source/core/editing/htmlediting.cpp:865: return createTabSpanElement(document, PassRefPtrWillBeRawPtr<Node>(nullptr)); On 2014/05/25 18:08:46, haraken wrote: > ...
6 years, 7 months ago (2014-05-25 18:11:23 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-25 20:53:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/294343007/1
6 years, 7 months ago (2014-05-25 20:53:24 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-25 22:07:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 174776

Powered by Google App Engine
This is Rietveld 408576698