Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2943373002: Updates gfx::Canvas scale command to accept float scale values (Closed)

Created:
3 years, 6 months ago by malaykeshav
Modified:
3 years, 6 months ago
Reviewers:
danakj, oshima
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates gfx::Canvas scale command to accept float scale values Currently gfx::Canvas does not accept float scale values, despite cc::PaintCanvas providing the API to allow non integral scale values. BUG=734684 COMPONENT=Gfx canvas Review-Url: https://codereview.chromium.org/2943373002 Cr-Commit-Position: refs/heads/master@{#480873} Committed: https://chromium.googlesource.com/chromium/src/+/f03bf279dbfb0d8324cf4894fe357ff1b1ec690e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/gfx/canvas.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
malaykeshav
PTAL
3 years, 6 months ago (2017-06-19 18:41:28 UTC) #3
oshima
lgtm
3 years, 6 months ago (2017-06-19 19:37:24 UTC) #5
malaykeshav
+danakj for OWNERS approval PTAL
3 years, 6 months ago (2017-06-19 20:12:07 UTC) #7
danakj
LGTM
3 years, 6 months ago (2017-06-20 15:27:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943373002/1
3 years, 6 months ago (2017-06-20 17:45:58 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 17:51:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f03bf279dbfb0d8324cf4894fe35...

Powered by Google App Engine
This is Rietveld 408576698