Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2943343003:
implement ios for translate event. (Closed)
|
Created:
3 years, 6 months ago by renjieliu1 Modified:
3 years, 5 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionImplement translate event for ios client.
BUG=728491
Review-Url: https://codereview.chromium.org/2943343003
Cr-Commit-Position: refs/heads/master@{#482872}
Committed: https://chromium.googlesource.com/chromium/src/+/edd3a026b008f41b7981b5b9786905d5d1b31b41
Patch Set 1 #Patch Set 2 : implement ios #Patch Set 3 : implement ios #Patch Set 4 : implement ios #Patch Set 5 : apply switch as well #
Total comments: 2
Patch Set 6 : rebase #
Messages
Total messages: 40 (29 generated)
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
Description was changed from ========== implement ios BUG=728491 ========== to ========== Implement translate event for ios client. BUG=728491 ==========
renjieliu@chromium.org changed reviewers: + napper@chromium.org
napper@chromium.org changed reviewers: + ramyasharma@chromium.org
The CQ bit was checked by renjieliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
apply switch as well, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
renjieliu@chromium.org changed reviewers: + patricialor@chromium.org
Hi Patti, can you help us doing an iOS review on the implementation?
lgtm https://codereview.chromium.org/2943343003/diff/80001/ios/chrome/browser/tran... File ios/chrome/browser/translate/chrome_ios_translate_client.mm (right): https://codereview.chromium.org/2943343003/diff/80001/ios/chrome/browser/tran... ios/chrome/browser/translate/chrome_ios_translate_client.mm:121: const auto* item = const auto* const
thanks for the review! https://codereview.chromium.org/2943343003/diff/80001/ios/chrome/browser/tran... File ios/chrome/browser/translate/chrome_ios_translate_client.mm (right): https://codereview.chromium.org/2943343003/diff/80001/ios/chrome/browser/tran... ios/chrome/browser/translate/chrome_ios_translate_client.mm:121: const auto* item = On 2017/06/27 01:29:58, napper wrote: > const auto* const Done.
renjieliu@chromium.org changed reviewers: + droger@chromium.org - patricialor@chromium.org
Hi David, can you review the translation event logging for ios? Thank you!
lgtm
The CQ bit was checked by renjieliu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from napper@chromium.org Link to the patchset: https://codereview.chromium.org/2943343003/#ps100001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by renjieliu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1498620726593280,
"parent_rev": "28fc48705db361c2fd93cd302c0d15c2a1ed8da4", "commit_rev":
"edd3a026b008f41b7981b5b9786905d5d1b31b41"}
Message was sent while issue was closed.
Description was changed from ========== Implement translate event for ios client. BUG=728491 ========== to ========== Implement translate event for ios client. BUG=728491 Review-Url: https://codereview.chromium.org/2943343003 Cr-Commit-Position: refs/heads/master@{#482872} Committed: https://chromium.googlesource.com/chromium/src/+/edd3a026b008f41b7981b5b97869... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/edd3a026b008f41b7981b5b97869... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
