Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2943313002: [ic] Make prototypes fast when storing through keyed store ic. (Closed)

Created:
3 years, 6 months ago by Jarin
Modified:
3 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Make prototypes fast when storing through keyed store IC. Toon suggested this as a mitigation to the problem of prototype fast mode switching invalidating prototype chain validity cell, and thus sending keyed store ICs to megamorphic state. BUG=chromium:723479 Review-Url: https://codereview.chromium.org/2943313002 Cr-Commit-Position: refs/heads/master@{#45993} Committed: https://chromium.googlesource.com/v8/v8/+/d6c9e534c862a07b0d027c746273aede07ce41c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/ic/ic.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please?
3 years, 6 months ago (2017-06-19 08:27:51 UTC) #5
Igor Sheludko
lgtm
3 years, 6 months ago (2017-06-19 08:32:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943313002/1
3 years, 6 months ago (2017-06-19 08:54:35 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 10:17:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d6c9e534c862a07b0d027c746273aede07c...

Powered by Google App Engine
This is Rietveld 408576698