Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSSkew.h

Issue 2943303002: [CSS Typed OM] Refactor is2D handling in CSSTransformComponents to match new spec (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSSkew.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSSkew.h b/third_party/WebKit/Source/core/css/cssom/CSSSkew.h
index ef234ed23445233a9fd5b53b1a9f7b529f28b4b2..bf8a4d1b4a339cf3e185f00ea5f1a9350718ec62 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSSkew.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSSkew.h
@@ -35,6 +35,11 @@ class CORE_EXPORT CSSSkew final : public CSSTransformComponent {
void setAx(CSSNumericValue*, ExceptionState&);
void setAy(CSSNumericValue*, ExceptionState&);
+ // From CSSTransformComponent
+ // Setting is2D for CSSSkew does nothing.
+ // https://drafts.css-houdini.org/css-typed-om/#dom-cssskew-is2d
+ void setIs2D(bool is2D) final {}
+
// Internal methods - from CSSTransformComponent.
DOMMatrix* AsMatrix() const override;
TransformComponentType GetType() const override { return kSkewType; }
@@ -48,7 +53,7 @@ class CORE_EXPORT CSSSkew final : public CSSTransformComponent {
private:
CSSSkew(CSSNumericValue* ax, CSSNumericValue* ay)
- : CSSTransformComponent(), ax_(ax), ay_(ay) {}
+ : CSSTransformComponent(true /* is2D */), ax_(ax), ay_(ay) {}
Member<CSSNumericValue> ax_;
Member<CSSNumericValue> ay_;

Powered by Google App Engine
This is Rietveld 408576698