third_party/WebKit/Source/core/css/cssom/CSSScale.cpp - Issue 2943303002: [CSS Typed OM] Refactor is2D handling in CSSTransformComponents to match new spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSScale.cpp

Issue 2943303002: [CSS Typed OM] Refactor is2D handling in CSSTransformComponents to match new spec (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSScale.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSScale.cpp b/third_party/WebKit/Source/core/css/cssom/CSSScale.cpp

index aea908826ef1b2e35890b06ac5cd9590398906f0..03a2791b84d1d774a7c0e2abfd02326ff91cdcff 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSScale.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSScale.cpp

@@ -64,13 +64,13 @@ CSSScale* CSSScale::FromCSSValue(const CSSFunctionValue& value) {

CSSFunctionValue* CSSScale::ToCSSValue() const {

CSSFunctionValue* result =

- CSSFunctionValue::Create(is2d_ ? CSSValueScale : CSSValueScale3d);

+ CSSFunctionValue::Create(is2D() ? CSSValueScale : CSSValueScale3d);

result->Append(

*CSSPrimitiveValue::Create(x_, CSSPrimitiveValue::UnitType::kNumber));

result->Append(

*CSSPrimitiveValue::Create(y_, CSSPrimitiveValue::UnitType::kNumber));

- if (!is2d_)

+ if (!is2D())

result->Append(

*CSSPrimitiveValue::Create(z_, CSSPrimitiveValue::UnitType::kNumber));