Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2943293002: [turbofan] Do constant-folding of JSHasInPrototypeChain early. (Closed)

Created:
3 years, 6 months ago by Benedikt Meurer
Modified:
3 years, 6 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Do constant-folding of JSHasInPrototypeChain early. We need to constant-fold JSHasInPrototypeChain nodes early during inlining, otherwise we already miss a couple of optimization opportunities if we wait until after typing. This moves the constant-folding part of the JSHasInPrototypeChain lowering back to JSNativeContextSpecialization, where it was before the changes in https://codereview.chromium.org/2934893002 (part of JSOrdinaryHasInstance lowering back then). BUG=v8:5269, v8:5989, v8:6483, chromium:733158 R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2943293002 Cr-Commit-Position: refs/heads/master@{#45989} Committed: https://chromium.googlesource.com/v8/v8/+/53b6f2767416f2a6dd539618831ffedbdfd540c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -76 lines) Patch
M src/compiler/js-native-context-specialization.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +78 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +0 lines, -64 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 6 months ago (2017-06-19 07:34:20 UTC) #1
Benedikt Meurer
Hey Jakob, Need to move furniture around (again). The early optimization is necessary, otherwise we ...
3 years, 6 months ago (2017-06-19 07:35:14 UTC) #4
jgruber
lgtm
3 years, 6 months ago (2017-06-19 07:41:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943293002/1
3 years, 6 months ago (2017-06-19 07:54:44 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 08:00:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/53b6f2767416f2a6dd539618831ffedbdfd...

Powered by Google App Engine
This is Rietveld 408576698