Forward BrowserAccessibility get_accState to AXPlatformNode.

content/browser/accessibility/browser_accessibility_com_win.cc

Index: content/browser/accessibility/browser_accessibility_com_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_com_win.cc b/content/browser/accessibility/browser_accessibility_com_win.cc
index 4695d7bfd0d1c5cdaf67519587a0fd8ebe46a6ae..6fd2264db44c7c6530315c9a29ff3a4416a9c5b1 100644
--- a/content/browser/accessibility/browser_accessibility_com_win.cc
+++ b/content/browser/accessibility/browser_accessibility_com_win.cc
@@ -631,23 +631,7 @@ STDMETHODIMP BrowserAccessibilityComWin::get_accState(VARIANT var_id,
   if (!owner())
     return E_FAIL;
 
-  auto* manager = Manager();
-  if (!manager)
-    return E_FAIL;
-
-  if (!state)
-    return E_INVALIDARG;
-
-  BrowserAccessibilityComWin* target = GetTargetFromChildID(var_id);
-  if (!target)
-    return E_INVALIDARG;
-
-  state->vt = VT_I4;
-  state->lVal = target->ia_state();
-  if (manager->GetFocus() == owner())
-    state->lVal |= STATE_SYSTEM_FOCUSED;
-
-  return S_OK;
+  return AXPlatformNodeWin::get_accState(var_id, state);

[dmazzoni, 2017/06/26 17:18:24]

We have duplicate code to compute ia_state now, which
makes me uneasy. It's needed because of firing events,
but ideally we should just fire the events based on
internal state changes and not keep track of ia_state
in this file.

Can you do one of the following:

1.) In InitRoleAndState(), just call the AXPlatformNodeWin
functions to get the role and state?
2.) Alternatively, add an ASSERT here that the state
returned from AXPlatformNodeWin matches ia_state, and
then add a TODO to InitRoleAndState?

[dougt, 2017/06/27 04:49:51]

Good call.  I found that MSAAState() and ia_state() differ when handling the
focus state.  Please take another look.

 }
 
 bool BrowserAccessibilityComWin::IsRangeValueSupported() {