Forward BrowserAccessibility get_accState to AXPlatformNode.

content/browser/accessibility/browser_accessibility_com_win.cc

 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_com_win.h"
 
 #include <UIAutomationClient.h>
 #include <UIAutomationCoreApi.h>
 
 #include <algorithm>
@@ skipping 613 matching lines @@
 
   return AXPlatformNodeWin::get_accRole(var_id, role);
 }
 
 STDMETHODIMP BrowserAccessibilityComWin::get_accState(VARIANT var_id,
                                                       VARIANT* state) {
   WIN_ACCESSIBILITY_API_HISTOGRAM(UMA_API_GET_ACC_STATE);
   if (!owner())
     return E_FAIL;
 
-  auto* manager = Manager();
-  if (!manager)
-    return E_FAIL;
-
-  if (!state)
-    return E_INVALIDARG;
-
-  BrowserAccessibilityComWin* target = GetTargetFromChildID(var_id);
-  if (!target)
-    return E_INVALIDARG;
-
-  state->vt = VT_I4;
-  state->lVal = target->ia_state();
-  if (manager->GetFocus() == owner())
-    state->lVal |= STATE_SYSTEM_FOCUSED;
-
-  return S_OK;
+  return AXPlatformNodeWin::get_accState(var_id, state);

[dmazzoni, 2017/06/26 17:18:24]

We have duplicate code to compute ia_state now, which
makes me uneasy. It's needed because of firing events,
but ideally we should just fire the events based on
internal state changes and not keep track of ia_state
in this file.

Can you do one of the following:

1.) In InitRoleAndState(), just call the AXPlatformNodeWin
functions to get the role and state?
2.) Alternatively, add an ASSERT here that the state
returned from AXPlatformNodeWin matches ia_state, and
then add a TODO to InitRoleAndState?

[dougt, 2017/06/27 04:49:51]

Good call.  I found that MSAAState() and ia_state() differ when handling the
focus state.  Please take another look.

 }
 
 bool BrowserAccessibilityComWin::IsRangeValueSupported() {
   switch (ia_role()) {
     case ROLE_SYSTEM_PROGRESSBAR:
     case ROLE_SYSTEM_SLIDER:
     case ROLE_SYSTEM_SPINBUTTON:
     case ROLE_SYSTEM_SCROLLBAR:
       return true;
     case ROLE_SYSTEM_SEPARATOR:
@@ skipping 4909 matching lines @@
 
 BrowserAccessibilityComWin* ToBrowserAccessibilityComWin(
     BrowserAccessibility* obj) {
   if (!obj || !obj->IsNative())
     return nullptr;
   auto* result = static_cast<BrowserAccessibilityWin*>(obj)->GetCOM();
   return result;
 }
 
 }  // namespace content