Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2943183002: Revert of Re-target wheel events only when a new scroll sequence has started. (Closed)

Created:
3 years, 6 months ago by nyquist
Modified:
3 years, 6 months ago
Reviewers:
bokan, sahel, tdresser
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, darin-cc_chromium.org, Navid Zolghadr, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-target wheel events only when a new scroll sequence has started. (patchset #7 id:220001 of https://codereview.chromium.org/2928793003/ ) Reason for revert: Flaky on Android Tests buildbot. First breaking build: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/42822 Original issue's description: > Re-target wheel events only when a new scroll sequence has started. > > In RouteMouseWheelEvent, when a wheel event with phase began arrives, > find the target for wheel event. While no wheel with phase end has > arrived (during a scroll sequence) send the wheel events to the saved > target. > > In EventHandler, do the same targetting to dispatch the events to js. > > BUG=526463 > TEST=WheelScrollLatchingBrowserTest.WheelEventTarget, > WheelScrollLatchingDisabledBrowserTest.WheelEventTarget > > Review-Url: https://codereview.chromium.org/2928793003 > Cr-Commit-Position: refs/heads/master@{#480052} > Committed: https://chromium.googlesource.com/chromium/src/+/8aa8c38005ee36bc441138c81a5cf165fb6514a5 TBR=bokan@chromium.org,tdresser@chromium.org,sahel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=526463 Review-Url: https://codereview.chromium.org/2943183002 Cr-Commit-Position: refs/heads/master@{#480171} Committed: https://chromium.googlesource.com/chromium/src/+/622b6164229bea82e61b916f5d9d41bc02b3488a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -370 lines) Patch
D content/browser/renderer_host/input/wheel_scroll_latching_browsertest.cc View 1 chunk +0 lines, -239 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 2 chunks +1 line, -27 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheel/wheelevent-basic.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheel/wheelevent-ctrl.html View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheel/wheelevent-in-scrolling-div.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheel/wheelevent-in-text-node.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/wheel/wheelevent-mousewheel-interaction.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/MouseWheelEventManager.h View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseWheelEventManager.cpp View 2 chunks +34 lines, -80 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nyquist
Created Revert of Re-target wheel events only when a new scroll sequence has started.
3 years, 6 months ago (2017-06-16 21:18:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943183002/1
3 years, 6 months ago (2017-06-16 21:18:30 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 21:19:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/622b6164229bea82e61b916f5d9d...

Powered by Google App Engine
This is Rietveld 408576698