Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2943133002: Async Wheel Event with only the first one cancellable behind a flag. (Closed)

Created:
3 years, 6 months ago by sahel
Modified:
3 years, 5 months ago
Reviewers:
kinuko, dtapuska
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Async Wheel Event with only the first one cancellable behind a flag. To test it locally use --enable-features=AsyncWheelEvents runtime flag. BUG=706175 TEST=MouseWheelEventQueueTests/*/2, LegacyInputRouterImplAsyncWheelEventEnabledTest/*, RenderWidgetHostAsyncWheelEventsEnabledTest Review-Url: https://codereview.chromium.org/2943133002 Cr-Commit-Position: refs/heads/master@{#482289} Committed: https://chromium.googlesource.com/chromium/src/+/44851965d0862ce66a1cad576686125ef8864d25

Patch Set 1 #

Patch Set 2 : format edited. #

Total comments: 4

Patch Set 3 : Async wheel tests added to RWHV_aura_unittests. #

Patch Set 4 : failing tests fixed. #

Total comments: 8

Patch Set 5 : review comments addressed. #

Total comments: 2

Patch Set 6 : 'k' removed from constant string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+826 lines, -289 lines) Patch
M content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc View 1 14 chunks +225 lines, -112 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 1 2 3 4 1 chunk +9 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 1 2 4 chunks +20 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 5 chunks +44 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 12 chunks +121 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 4 5 43 chunks +381 lines, -146 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 43 (31 generated)
sahel
3 years, 6 months ago (2017-06-16 17:32:19 UTC) #5
dtapuska
https://codereview.chromium.org/2943133002/diff/20001/content/browser/renderer_host/input/mouse_wheel_event_queue.cc File content/browser/renderer_host/input/mouse_wheel_event_queue.cc (right): https://codereview.chromium.org/2943133002/diff/20001/content/browser/renderer_host/input/mouse_wheel_event_queue.cc#newcode274 content/browser/renderer_host/input/mouse_wheel_event_queue.cc:274: if (base::FeatureList::IsEnabled(features::kAsyncWheelEvents)) { don't check the feature list on ...
3 years, 6 months ago (2017-06-16 17:36:09 UTC) #6
sahel
https://codereview.chromium.org/2943133002/diff/20001/content/browser/renderer_host/input/mouse_wheel_event_queue.cc File content/browser/renderer_host/input/mouse_wheel_event_queue.cc (right): https://codereview.chromium.org/2943133002/diff/20001/content/browser/renderer_host/input/mouse_wheel_event_queue.cc#newcode274 content/browser/renderer_host/input/mouse_wheel_event_queue.cc:274: if (base::FeatureList::IsEnabled(features::kAsyncWheelEvents)) { On 2017/06/16 17:36:09, dtapuska wrote: > ...
3 years, 6 months ago (2017-06-20 19:22:33 UTC) #18
dtapuska
https://codereview.chromium.org/2943133002/diff/80001/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc File content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc (right): https://codereview.chromium.org/2943133002/diff/80001/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc#newcode1073 content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc:1073: void LegacyInputRouterImplTest::UnhandledWheelEvent() { Moving code around like this makes ...
3 years, 6 months ago (2017-06-20 20:53:15 UTC) #19
sahel
https://codereview.chromium.org/2943133002/diff/80001/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc File content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc (right): https://codereview.chromium.org/2943133002/diff/80001/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc#newcode1073 content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc:1073: void LegacyInputRouterImplTest::UnhandledWheelEvent() { On 2017/06/20 20:53:14, dtapuska wrote: > ...
3 years, 6 months ago (2017-06-21 18:09:59 UTC) #28
dtapuska
On 2017/06/21 18:09:59, sahel wrote: > https://codereview.chromium.org/2943133002/diff/80001/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc > File content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc > (right): > > https://codereview.chromium.org/2943133002/diff/80001/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc#newcode1073 ...
3 years, 6 months ago (2017-06-21 20:31:51 UTC) #29
sahel
pfeldman@chromium.org: Please review changes in content/browser/renderer_host/render_widget_host_unittest.cc content/browser/renderer_host/render_widget_host_view_aura_unittest.cc content/public/common/content_features.*
3 years, 6 months ago (2017-06-21 21:04:53 UTC) #31
sahel
kinuko@chromium.org: Please review changes in content/browser/renderer_host/render_widget_host_unittest.cc content/browser/renderer_host/render_widget_host_view_aura_unittest.cc content/public/common/content_features.*
3 years, 6 months ago (2017-06-22 20:39:07 UTC) #34
kinuko
lgtm https://codereview.chromium.org/2943133002/diff/100001/content/public/common/content_features.cc File content/public/common/content_features.cc (right): https://codereview.chromium.org/2943133002/diff/100001/content/public/common/content_features.cc#newcode25 content/public/common/content_features.cc:25: const base::Feature kAsyncWheelEvents{"kAsyncWheelEvents", Per the issue description (and ...
3 years, 6 months ago (2017-06-26 03:37:31 UTC) #35
sahel
https://codereview.chromium.org/2943133002/diff/100001/content/public/common/content_features.cc File content/public/common/content_features.cc (right): https://codereview.chromium.org/2943133002/diff/100001/content/public/common/content_features.cc#newcode25 content/public/common/content_features.cc:25: const base::Feature kAsyncWheelEvents{"kAsyncWheelEvents", On 2017/06/26 03:37:31, kinuko wrote: > ...
3 years, 5 months ago (2017-06-26 15:26:39 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943133002/130001
3 years, 5 months ago (2017-06-26 15:26:47 UTC) #40
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 16:35:05 UTC) #43
Message was sent while issue was closed.
Committed patchset #6 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/44851965d0862ce66a1cad576686...

Powered by Google App Engine
This is Rietveld 408576698