Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2943123002:
Adding links to Safe browsing info to group policy descriptions (Closed)
DescriptionAdding links to Safe browsing info to group policy descriptions
BUG=None
Review-Url: https://codereview.chromium.org/2943123002
Cr-Commit-Position: refs/heads/master@{#480446}
Committed: https://chromium.googlesource.com/chromium/src/+/a31f81660ebee36aa028f0ce9099d9c1ee375a30
Patch Set 1 #
Total comments: 2
Messages
Total messages: 13 (5 generated)
mad@chromium.org changed reviewers: + pastarmovj@chromium.org
As requested... Thanks! BYE MAD
lgtm
The CQ bit was checked by mad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497881637356670, "parent_rev":
"4f7a4c8b074a1801729d351217b719fee1244b90", "commit_rev":
"a31f81660ebee36aa028f0ce9099d9c1ee375a30"}
Message was sent while issue was closed.
Description was changed from ========== Adding links to Safe browsing info to group policy descriptions BUG=None ========== to ========== Adding links to Safe browsing info to group policy descriptions BUG=None Review-Url: https://codereview.chromium.org/2943123002 Cr-Commit-Position: refs/heads/master@{#480446} Committed: https://chromium.googlesource.com/chromium/src/+/a31f81660ebee36aa028f0ce9099... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a31f81660ebee36aa028f0ce9099...
Message was sent while issue was closed.
thestig@chromium.org changed reviewers: + thestig@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2943123002/diff/1/components/policy/resources... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2943123002/diff/1/components/policy/resources... components/policy/resources/policy_templates.json:1283: See https://developers.google.com/safe-browsing for more info on SafeBrowsing.''', Does the double spacing after the word "for" show up in some user visible way?
Message was sent while issue was closed.
https://codereview.chromium.org/2943123002/diff/1/components/policy/resources... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2943123002/diff/1/components/policy/resources... components/policy/resources/policy_templates.json:1283: See https://developers.google.com/safe-browsing for more info on SafeBrowsing.''', On 2017/06/19 23:36:41, Lei Zhang wrote: > Does the double spacing after the word "for" show up in some user visible way? Oups, I missed that. Julian, do you know how this text is parsed and displayed by the policy admin tool thingy? Anyway, I think it's cleaner if I fix it, thanks for pointing this out Lei.
Message was sent while issue was closed.
On 2017/06/20 14:58:21, MAD wrote: > https://codereview.chromium.org/2943123002/diff/1/components/policy/resources... > File components/policy/resources/policy_templates.json (right): > > https://codereview.chromium.org/2943123002/diff/1/components/policy/resources... > components/policy/resources/policy_templates.json:1283: See > https://developers.google.com/safe-browsing for more info on SafeBrowsing.''', > On 2017/06/19 23:36:41, Lei Zhang wrote: > > Does the double spacing after the word "for" show up in some user visible way? > > Oups, I missed that. > Julian, do you know how this text is parsed and displayed by the policy admin > tool thingy? > > Anyway, I think it's cleaner if I fix it, thanks for pointing this out Lei. It is used in various ways to generate the documentation for ADM[X] templates, for generating a sample JSON file for Linux and to generate the HTML of the policy web page. Some of those take the contents as text so this double spacing would have occurred there.
Message was sent while issue was closed.
OK, thanks for the info! :-) Le mar. 20 juin 2017 à 13:15, <pastarmovj@chromium.org> a écrit : > On 2017/06/20 14:58:21, MAD wrote: > > > > https://codereview.chromium.org/2943123002/diff/1/components/policy/resources... > > File components/policy/resources/policy_templates.json (right): > > > > > > https://codereview.chromium.org/2943123002/diff/1/components/policy/resources... > > components/policy/resources/policy_templates.json:1283: See > > https://developers.google.com/safe-browsing for more info on > SafeBrowsing.''', > > On 2017/06/19 23:36:41, Lei Zhang wrote: > > > Does the double spacing after the word "for" show up in some user > visible > way? > > > > Oups, I missed that. > > Julian, do you know how this text is parsed and displayed by the policy > admin > > tool thingy? > > > > Anyway, I think it's cleaner if I fix it, thanks for pointing this out > Lei. > > It is used in various ways to generate the documentation for ADM[X] > templates, > for generating a sample JSON file for Linux and to generate the HTML of the > policy web page. Some of those take the contents as text so this double > spacing > would have occurred there. > > https://codereview.chromium.org/2943123002/ > -- BYE MAD... -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
