Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2943103003: Migrate web-page-replay-go files (Closed)

Created:
3 years, 6 months ago by xunjieli
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Migrate web-page-replay-go files This CL adds remaining files for web-page-replay-go NOPRESUBMIT=true BUG=catapult:#3629 Review-Url: https://codereview.chromium.org/2943103003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a925a18910d339df62e2c46ce2cafdda9bef67db

Patch Set 1 #

Patch Set 2 : self #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -1 line) Patch
A web_page_replay_go/deterministic.js View 1 1 chunk +68 lines, -0 lines 1 comment Download
M web_page_replay_go/src/webpagereplay/proxy.go View 1 chunk +1 line, -1 line 0 comments Download
A web_page_replay_go/wpr_cert.pem View 1 chunk +15 lines, -0 lines 0 comments Download
A web_page_replay_go/wpr_key.pem View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
xunjieli
3 years, 6 months ago (2017-06-16 13:55:14 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-16 13:57:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943103003/1
3 years, 6 months ago (2017-06-16 14:30:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/7518)
3 years, 6 months ago (2017-06-16 14:32:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2943103003/20001
3 years, 6 months ago (2017-06-16 15:07:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a925a18910d339df62e2c46ce2cafdda9bef67db
3 years, 6 months ago (2017-06-16 15:32:37 UTC) #14
nednguyen
3 years, 6 months ago (2017-06-16 17:13:06 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2943103003/diff/20001/web_page_replay_go/dete...
File web_page_replay_go/deterministic.js (right):

https://codereview.chromium.org/2943103003/diff/20001/web_page_replay_go/dete...
web_page_replay_go/deterministic.js:34: var time_seed = 1204251968254;
at some point we should fix the time_see here to be a place holder that is to be
filled by time of the recording.

Powered by Google App Engine
This is Rietveld 408576698