Introduce Find{Left,Right}BidiRun() and utilize in AdjustInlineBoxPositionForTextDirection()

Introduce Find{Left,Right}BidiRun() and utilize in AdjustInlineBoxPositionForTextDirection()

This patch introduces |Find{Left,Right}BidiRun()| in |InlineBoxTraversal| to
unify common pattern into function for improving of readability.

Before this patch:
  InlineBox* result = start;
  do {
    result = result->Forward();
  } while (result && result->BidiLevel() > level);
  ... use result ...

After this patch:
  InlineBox* Find(InlineBox* start, unsigned level) {
    for (InlineBox* runner = start->Forward(); runner;
         runner = runner->Forward()) {
      if (runner->BidiLevel() <= level)
        return runner;
    }
    return nullptr;
  }
  InlineBox* result = Find(start, level);
  ... use result ...

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2943053002
Cr-Commit-Position: refs/heads/master@{#480340}
Committed: https://chromium.googlesource.com/chromium/src/+/add3c68a6c8aea99a4f7088193f99d5eaaa5b510

[yosin_UTC9, 2017-06-16 04:11:09]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 04:11:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-16 04:53:36]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 04:53:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-16 04:53:51]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-06-16 04:54:31]

Description was changed from

==========
2017-06-16T13:08:30

BUG=707656

2017-06-16T13:08:13
==========

to

==========
Introduce Find{Left,Right}BidiRun() in InlineBoxTraversal

This patch introduces |Find{Left,Right}BidiRun()| in |InlineBoxTraversal| to
unify common pattern into function for improving of readability.

Before this patch:
  InlineBox* result = start;
  do {
    result = result->Forward();
  } while (result && result->BidiLevel() > level);
  ... use result ...

After this patch:
  InlineBox* Find(InlineBox* start, unsigned level) {
    for (InlineBox* runner = start->Forward(); runner;
         runner = runner->Forward()) {
      if (runner->BidiLevel() <= level)
        return runner;
    }
    return nullptr;
  }
  InlineBox* result = Find(start, level);
  ... use result ...

BUG=707656
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-16 04:54:58]

Description was changed from

==========
Introduce Find{Left,Right}BidiRun() in InlineBoxTraversal

This patch introduces |Find{Left,Right}BidiRun()| in |InlineBoxTraversal| to
unify common pattern into function for improving of readability.

Before this patch:
  InlineBox* result = start;
  do {
    result = result->Forward();
  } while (result && result->BidiLevel() > level);
  ... use result ...

After this patch:
  InlineBox* Find(InlineBox* start, unsigned level) {
    for (InlineBox* runner = start->Forward(); runner;
         runner = runner->Forward()) {
      if (runner->BidiLevel() <= level)
        return runner;
    }
    return nullptr;
  }
  InlineBox* result = Find(start, level);
  ... use result ...

BUG=707656
TEST=n/a; no behavior changes
==========

to

==========
Introduce Find{Left,Right}BidiRun() and utilize in
AdjustInlineBoxPositionForTextDirection()

This patch introduces |Find{Left,Right}BidiRun()| in |InlineBoxTraversal| to
unify common pattern into function for improving of readability.

Before this patch:
  InlineBox* result = start;
  do {
    result = result->Forward();
  } while (result && result->BidiLevel() > level);
  ... use result ...

After this patch:
  InlineBox* Find(InlineBox* start, unsigned level) {
    for (InlineBox* runner = start->Forward(); runner;
         runner = runner->Forward()) {
      if (runner->BidiLevel() <= level)
        return runner;
    }
    return nullptr;
  }
  InlineBox* result = Find(start, level);
  ... use result ...

BUG=707656
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-16 06:37:00]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-16 06:37:01]

PTAL

[commit-bot: I haz the power, 2017-06-16 06:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 06:41:33]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-06-16 18:30:57]

lgtm

[yosin_UTC9, 2017-06-17 03:01:52]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-17 03:01:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 03:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-17 03:04:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2017-06-19 01:57:57]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-19 01:58:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 03:46:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497837477504510,
"parent_rev": "2a3854354e0d85a1ba68d3468795a261c4a72052", "commit_rev":
"f653433a017d0b4892b91d6372cab5ebd04dc6fc"}

[commit-bot: I haz the power, 2017-06-19 03:47:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497837477504510,
"parent_rev": "b81391a1463e01627551df0c4520581aa3118c4e", "commit_rev":
"add3c68a6c8aea99a4f7088193f99d5eaaa5b510"}

[commit-bot: I haz the power, 2017-06-19 03:47:21]

Description was changed from

==========
Introduce Find{Left,Right}BidiRun() and utilize in
AdjustInlineBoxPositionForTextDirection()

This patch introduces |Find{Left,Right}BidiRun()| in |InlineBoxTraversal| to
unify common pattern into function for improving of readability.

Before this patch:
  InlineBox* result = start;
  do {
    result = result->Forward();
  } while (result && result->BidiLevel() > level);
  ... use result ...

After this patch:
  InlineBox* Find(InlineBox* start, unsigned level) {
    for (InlineBox* runner = start->Forward(); runner;
         runner = runner->Forward()) {
      if (runner->BidiLevel() <= level)
        return runner;
    }
    return nullptr;
  }
  InlineBox* result = Find(start, level);
  ... use result ...

BUG=707656
TEST=n/a; no behavior changes
==========

to

==========
Introduce Find{Left,Right}BidiRun() and utilize in
AdjustInlineBoxPositionForTextDirection()

This patch introduces |Find{Left,Right}BidiRun()| in |InlineBoxTraversal| to
unify common pattern into function for improving of readability.

Before this patch:
  InlineBox* result = start;
  do {
    result = result->Forward();
  } while (result && result->BidiLevel() > level);
  ... use result ...

After this patch:
  InlineBox* Find(InlineBox* start, unsigned level) {
    for (InlineBox* runner = start->Forward(); runner;
         runner = runner->Forward()) {
      if (runner->BidiLevel() <= level)
        return runner;
    }
    return nullptr;
  }
  InlineBox* result = Find(start, level);
  ... use result ...

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2943053002
Cr-Commit-Position: refs/heads/master@{#480340}
Committed:
https://chromium.googlesource.com/chromium/src/+/add3c68a6c8aea99a4f7088193f9...
==========

[commit-bot: I haz the power, 2017-06-19 03:47:22]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/add3c68a6c8aea99a4f7088193f9...