Add some speed documentation:

Add some speed documentation:

* README.md, which is intended to be the main landing site for
  go/chrome-speed
* how_does_chrome_measure_performance.md, which matches our original
  outline pretty closely.
* addressing_performance_regressions.md, which had a few differences
  from our original outline:
  - I felt it was better to put eveything in one doc, since I do stuff
    like refer to the bisect bot output in multiple sections.
  - I added a LOT more detail than I think we originally had slated.
  - I added a "it's not my cl!" section.

There's still a long way to go, but I think this is a good base.

TBR=simonhatch@chromium.org,nednguyen@chromium.org

Review-Url: https://codereview.chromium.org/2943013003
Cr-Commit-Position: refs/heads/master@{#480118}
Committed: https://chromium.googlesource.com/chromium/src/+/c3535a7dfd22fc8f19983c216c4ef8a52172a5f5

[sullivan, 2017-06-16 04:26:07]

sullivan@chromium.org changed reviewers:
+ benhenry@chromium.org

[benhenry, 2017-06-16 18:01:28]

benhenry@google.com changed reviewers:
+ benhenry@google.com

[benhenry, 2017-06-16 18:01:28]

Minor nits, but lgtm either way.

https://codereview.chromium.org/2943013003/diff/1/docs/speed/README.md
File docs/speed/README.md (right):

https://codereview.chromium.org/2943013003/diff/1/docs/speed/README.md#newcode5
docs/speed/README.md:5: * **Contact**: chrome-speed@google.com
Can we make this TBD for now?

https://codereview.chromium.org/2943013003/diff/1/docs/speed/README.md#newcode26
docs/speed/README.md:26: * General discussion:
chrome-speed-operations@google.com
Are you ok taking out things with @google email right now? Also, since this is
in the open source, maybe we should think about which of these are necessary for
all people vs. googlers.

[sullivan, 2017-06-16 18:53:54]

I addressed your comments and I'm going to CQ this now.

https://codereview.chromium.org/2943013003/diff/1/docs/speed/README.md
File docs/speed/README.md (right):

https://codereview.chromium.org/2943013003/diff/1/docs/speed/README.md#newcode5
docs/speed/README.md:5: * **Contact**: chrome-speed@google.com
On 2017/06/16 18:01:28, benhenry wrote:
> Can we make this TBD for now?

Yep! Do you think it's reasonable to have something figured out by Thursday
though?

https://codereview.chromium.org/2943013003/diff/1/docs/speed/README.md#newcode26
docs/speed/README.md:26: * General discussion:
chrome-speed-operations@google.com
On 2017/06/16 18:01:28, benhenry wrote:
> Are you ok taking out things with @google email right now? Also, since this is
> in the open source, maybe we should think about which of these are necessary
for
> all people vs. googlers.

I took these out for now. FWIW I really like the memory documentation's use of
chromium vs google mails:
https://chromium.googlesource.com/chromium/src/+/master/docs/memory

It links google.com mailing lists but it has a clear rationale of why each list
exists and when to use them. I think it's fine for us to put google.com lists
back in the documentation when our mailing list story is that crisp. Do you
agree?

[sullivan, 2017-06-16 18:53:58]

The CQ bit was checked by sullivan@chromium.org

[sullivan, 2017-06-16 18:53:59]

The patchset sent to the CQ was uploaded after l-g-t-m from benhenry@google.com
Link to the patchset: https://codereview.chromium.org/2943013003/#ps20001
(title: "Removed references to google.com mailing lists.")

[commit-bot: I haz the power, 2017-06-16 18:54:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 18:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 18:54:29]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[sullivan, 2017-06-16 18:57:10]

Description was changed from

==========
Add some speed documentation:

* README.md, which is intended to be the main landing site for
  go/chrome-speed
* how_does_chrome_measure_performance.md, which matches our original
  outline pretty closely.
* addressing_performance_regressions.md, which had a few differences
  from our original outline:
  - I felt it was better to put eveything in one doc, since I do stuff
    like refer to the bisect bot output in multiple sections.
  - I added a LOT more detail than I think we originally had slated.
  - I added a "it's not my cl!" section.

There's still a long way to go, but I think this is a good base.
==========

to

==========
Add some speed documentation:

* README.md, which is intended to be the main landing site for
  go/chrome-speed
* how_does_chrome_measure_performance.md, which matches our original
  outline pretty closely.
* addressing_performance_regressions.md, which had a few differences
  from our original outline:
  - I felt it was better to put eveything in one doc, since I do stuff
    like refer to the bisect bot output in multiple sections.
  - I added a LOT more detail than I think we originally had slated.
  - I added a "it's not my cl!" section.

There's still a long way to go, but I think this is a good base.

TBR=simonhatch@chromium.org,nednguyen@chromium.org
==========

[sullivan, 2017-06-16 18:58:06]

Adding Simon and Ned as TBR since Ben isn't a full committer, and my
understanding is that the policy is that TBR is fine for documentation changes.

Simon, Ned: Ben and I are doing a hackathon on speed docs. Any feedback welcome!

[sullivan, 2017-06-16 18:58:10]

The CQ bit was checked by sullivan@chromium.org

[commit-bot: I haz the power, 2017-06-16 18:58:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benhenry, 2017-06-16 18:59:10]

On 2017/06/16 18:58:37, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

That's weird. I'm in the OWNERS file. Did I do something wrong?

[sullivan, 2017-06-16 19:00:50]

On 2017/06/16 18:59:10, benhenry wrote:
> On 2017/06/16 18:58:37, commit-bot: I haz the power wrote:
> > CQ is trying da patch.
> > 
> > Follow status at:
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> That's weird. I'm in the OWNERS file. Did I do something wrong?

Are you a chromium committer? It's a different process than OWNERS:
https://www.chromium.org/getting-involved/become-a-committer

[commit-bot: I haz the power, 2017-06-16 19:12:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497639490292780,
"parent_rev": "adca986a53b31b6da4cb22f8e755f6856daea89a", "commit_rev":
"c3535a7dfd22fc8f19983c216c4ef8a52172a5f5"}

[commit-bot: I haz the power, 2017-06-16 19:13:10]

Description was changed from

==========
Add some speed documentation:

* README.md, which is intended to be the main landing site for
  go/chrome-speed
* how_does_chrome_measure_performance.md, which matches our original
  outline pretty closely.
* addressing_performance_regressions.md, which had a few differences
  from our original outline:
  - I felt it was better to put eveything in one doc, since I do stuff
    like refer to the bisect bot output in multiple sections.
  - I added a LOT more detail than I think we originally had slated.
  - I added a "it's not my cl!" section.

There's still a long way to go, but I think this is a good base.

TBR=simonhatch@chromium.org,nednguyen@chromium.org
==========

to

==========
Add some speed documentation:

* README.md, which is intended to be the main landing site for
  go/chrome-speed
* how_does_chrome_measure_performance.md, which matches our original
  outline pretty closely.
* addressing_performance_regressions.md, which had a few differences
  from our original outline:
  - I felt it was better to put eveything in one doc, since I do stuff
    like refer to the bisect bot output in multiple sections.
  - I added a LOT more detail than I think we originally had slated.
  - I added a "it's not my cl!" section.

There's still a long way to go, but I think this is a good base.

TBR=simonhatch@chromium.org,nednguyen@chromium.org

Review-Url: https://codereview.chromium.org/2943013003
Cr-Commit-Position: refs/heads/master@{#480118}
Committed:
https://chromium.googlesource.com/chromium/src/+/c3535a7dfd22fc8f19983c216c4e...
==========

[commit-bot: I haz the power, 2017-06-16 19:13:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c3535a7dfd22fc8f19983c216c4e...