corrected wrong options showing on context menus.

Corrected wrong options showing on context menus

* Added share link to link menu.

* Fixed sizing issue that would cause extra white space on the menu
with fewer selectable items

* Created new fields for share link.

* Fixed ordering of context menu items & text to match design specs.

* Added functionality to share links

BUG=730328
Review-Url: https://codereview.chromium.org/2942963002
Cr-Commit-Position: refs/heads/master@{#480547}
Committed: https://chromium.googlesource.com/chromium/src/+/5d74fae906a139649f7e59304d49e832f27d4528

[Daniel Park, 2017-06-15 21:35:49]

danielpark@chromium.org changed reviewers:
+ danielpark@chromium.org, dfalcantara@chromium.org, twellington@chromium.org

[gone, 2017-06-15 21:43:31]

Try to format your commit messages like this maybe?

-----------------------------------------------------------------------
Corrected wrong options showing on context menus

* Added share link to link menu.

* Fixed sizing issue that would cause extra white space on the menu
  with fewer selectable items

* Created new fields for share link.

* Fixed ordering of context menu items & text to match design specs.
  'Share link...' still needs to be added.

* TODO: Waiting for ltian's patch to merge so shareLink can be called.

BUG=730328
-----------------------------------------------------------------------

[gone, 2017-06-15 22:05:11]

+ changes to commit message I suggested in my last comment.

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
(right):

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java:64:
public Activity getActivity() {
1) package protected instead of public

2) add javadoc

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1709: Copy link
Are these changes intentional?

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1715: Download page
Same as above.

[Daniel Park, 2017-06-16 00:03:15]

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
(right):

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java:64:
public Activity getActivity() {
On 2017/06/15 22:05:11, dfalcantara wrote:
> 1) package protected instead of public
> 
> 2) add javadoc

Done.

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1709: Copy link
On 2017/06/15 22:05:11, dfalcantara wrote:
> Are these changes intentional?

this was done to match the design specs.
https://bbergher.googleplex.com/specs/context-menu/static/

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1709: Copy link
On 2017/06/15 22:05:11, dfalcantara wrote:
> Are these changes intentional?

Acknowledged.

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1715: Download page
On 2017/06/15 22:05:11, dfalcantara wrote:
> Same as above.

this was done to match the design specs.
https://bbergher.googleplex.com/specs/context-menu/static/

https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1715: Download page
On 2017/06/15 22:05:11, dfalcantara wrote:
> Same as above.

Acknowledged.

[gone, 2017-06-16 00:09:42]

On 2017/06/16 00:03:15, Daniel Park wrote:
>
https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
> (right):
> 
>
https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java:64:
> public Activity getActivity() {
> On 2017/06/15 22:05:11, dfalcantara wrote:
> > 1) package protected instead of public
> > 
> > 2) add javadoc
> 
> Done.
> 
>
https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
> File chrome/android/java/strings/android_chrome_strings.grd (right):
> 
>
https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
> chrome/android/java/strings/android_chrome_strings.grd:1709: Copy link
> On 2017/06/15 22:05:11, dfalcantara wrote:
> > Are these changes intentional?
> 
> this was done to match the design specs.
> https://bbergher.googleplex.com/specs/context-menu/static/
> 
>
https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
> chrome/android/java/strings/android_chrome_strings.grd:1709: Copy link
> On 2017/06/15 22:05:11, dfalcantara wrote:
> > Are these changes intentional?
> 
> Acknowledged.
> 
>
https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
> chrome/android/java/strings/android_chrome_strings.grd:1715: Download page
> On 2017/06/15 22:05:11, dfalcantara wrote:
> > Same as above.
> 
> this was done to match the design specs.
> https://bbergher.googleplex.com/specs/context-menu/static/
> 
>
https://codereview.chromium.org/2942963002/diff/1/chrome/android/java/strings...
> chrome/android/java/strings/android_chrome_strings.grd:1715: Download page
> On 2017/06/15 22:05:11, dfalcantara wrote:
> > Same as above.
> 
> Acknowledged.

Still gotta update the commit message.

[Daniel Park, 2017-06-16 17:19:18]

Description was changed from

==========
corrected wrong options showing on context menus.
added share link to link menu.
fixed sizing issue that would cause extra white space on the menu with fewer
selectable items


created new fields for share link. todo: wait for lei's patch to merge, then use
it to call shareLink


Fixed ordering of context menu items & text to match design specs. 'Share
link...' still needs to be added.

BUG=730328
==========

to

==========
Corrected wrong options showing on context menus

* Added share link to link menu.

* Fixed sizing issue that would cause extra white space on the menu
with fewer selectable items

* Created new fields for share link.

* Fixed ordering of context menu items & text to match design specs.
'Share link...' still needs to be added.

* TODO: Waiting for ltian's patch to merge so shareLink can be called.

BUG=730328
==========

[Daniel Park, 2017-06-16 17:19:48]

Description was changed from

==========
Corrected wrong options showing on context menus

* Added share link to link menu.

* Fixed sizing issue that would cause extra white space on the menu
with fewer selectable items

* Created new fields for share link.

* Fixed ordering of context menu items & text to match design specs.
'Share link...' still needs to be added.

* TODO: Waiting for ltian's patch to merge so shareLink can be called.

BUG=730328
==========

to

==========
Corrected wrong options showing on context menus

* Added share link to link menu.

* Fixed sizing issue that would cause extra white space on the menu
with fewer selectable items

* Created new fields for share link.

* Fixed ordering of context menu items & text to match design specs.

* Added functionality to share links

BUG=730328
==========

[Daniel Park, 2017-06-16 17:20:05]

danielpark@chromium.org changed reviewers:
- twellington@chromium.org

[gone, 2017-06-16 17:20:45]

lgtm

[Daniel Park, 2017-06-16 17:21:13]

The CQ bit was checked by danielpark@chromium.org

[commit-bot: I haz the power, 2017-06-16 17:21:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 19:33:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 19:33:45]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Daniel Park, 2017-06-16 23:24:13]

i removed copy link text from the chrome context menu & any affiliated places. 

i kept it in ids.xml because another class needs it.

[Daniel Park, 2017-06-19 16:51:23]

The CQ bit was checked by danielpark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 16:51:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 17:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 17:22:32]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Daniel Park, 2017-06-19 18:52:19]

The CQ bit was checked by danielpark@chromium.org to run a CQ dry run

[Daniel Park, 2017-06-19 18:52:22]

The CQ bit was unchecked by danielpark@chromium.org

[Daniel Park, 2017-06-19 18:52:27]

The CQ bit was checked by danielpark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 18:53:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 19:45:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 19:45:33]

Dry run: This issue passed the CQ dry run.

[Daniel Park, 2017-06-19 19:52:17]

The CQ bit was checked by danielpark@chromium.org

[Daniel Park, 2017-06-19 19:52:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2942963002/#ps60001
(title: "Updated ChromeContextMenuPopulatorTest")

[commit-bot: I haz the power, 2017-06-19 19:52:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 19:57:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497901937339580,
"parent_rev": "a5a9c28b95597856f7bd0210a406ea7e33db3ccb", "commit_rev":
"5d74fae906a139649f7e59304d49e832f27d4528"}

[commit-bot: I haz the power, 2017-06-19 19:57:40]

Description was changed from

==========
Corrected wrong options showing on context menus

* Added share link to link menu.

* Fixed sizing issue that would cause extra white space on the menu
with fewer selectable items

* Created new fields for share link.

* Fixed ordering of context menu items & text to match design specs.

* Added functionality to share links

BUG=730328
==========

to

==========
Corrected wrong options showing on context menus

* Added share link to link menu.

* Fixed sizing issue that would cause extra white space on the menu
with fewer selectable items

* Created new fields for share link.

* Fixed ordering of context menu items & text to match design specs.

* Added functionality to share links

BUG=730328

Review-Url: https://codereview.chromium.org/2942963002
Cr-Commit-Position: refs/heads/master@{#480547}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d74fae906a139649f7e59304d49...
==========

[commit-bot: I haz the power, 2017-06-19 19:57:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5d74fae906a139649f7e59304d49...