Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 2942943002: [WebPayments] Setting hidden views in view stack invisible (Closed)

Created:
3 years, 6 months ago by tmartino
Modified:
3 years, 6 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebPayments] Setting hidden views in view stack invisible Setting visibility on these views is important, among other reasons, for screen reader purposes. BUG=733684 Review-Url: https://codereview.chromium.org/2942943002 Cr-Commit-Position: refs/heads/master@{#480549} Committed: https://chromium.googlesource.com/chromium/src/+/0c486ef46927e0b1aef9f8b352b4aaedebb4ca5b

Patch Set 1 #

Total comments: 1

Patch Set 2 : \ #

Patch Set 3 : anthony feedback 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M chrome/browser/ui/views/payments/view_stack.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/view_stack.cc View 1 2 4 chunks +37 lines, -15 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
tmartino
3 years, 6 months ago (2017-06-15 21:59:52 UTC) #7
anthonyvd
https://codereview.chromium.org/2942943002/diff/1/chrome/browser/ui/views/payments/view_stack.cc File chrome/browser/ui/views/payments/view_stack.cc (right): https://codereview.chromium.org/2942943002/diff/1/chrome/browser/ui/views/payments/view_stack.cc#newcode55 chrome/browser/ui/views/payments/view_stack.cc:55: if (size()) Doesn't this make the view invisible before ...
3 years, 6 months ago (2017-06-16 15:48:21 UTC) #8
tmartino
PTAL
3 years, 6 months ago (2017-06-16 22:09:38 UTC) #17
anthonyvd
lgtm
3 years, 6 months ago (2017-06-19 18:47:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942943002/40001
3 years, 6 months ago (2017-06-19 18:52:12 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 20:01:33 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0c486ef46927e0b1aef9f8b352b4...

Powered by Google App Engine
This is Rietveld 408576698