[WebPayments] Setting hidden views in view stack invisible

[WebPayments] Setting hidden views in view stack invisible

Setting visibility on these views is important, among other
reasons, for screen reader purposes.

BUG=733684
Review-Url: https://codereview.chromium.org/2942943002
Cr-Commit-Position: refs/heads/master@{#480549}
Committed: https://chromium.googlesource.com/chromium/src/+/0c486ef46927e0b1aef9f8b352b4aaedebb4ca5b

[tmartino, 2017-06-15 20:24:00]

Description was changed from

==========
[WebPayments] Setting hidden views in view stack invisible

BUG=733684
==========

to

==========
[WebPayments] Setting hidden views in view stack invisible

Setting visibility on these views is important, among other
reasons, for screen reader purposes.

BUG=733684
==========

[tmartino, 2017-06-15 20:24:00]

tmartino@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[tmartino, 2017-06-15 20:25:59]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 20:26:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 21:35:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 21:35:26]

Dry run: This issue passed the CQ dry run.

[anthonyvd, 2017-06-16 15:48:21]

https://codereview.chromium.org/2942943002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/view_stack.cc (right):

https://codereview.chromium.org/2942943002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/view_stack.cc:55: if (size())
Doesn't this make the view invisible before the animation starts? We probably
need to observe the animation and call this when it's over.

[tmartino, 2017-06-16 17:00:50]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 17:01:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 18:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 18:21:23]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-06-16 20:59:44]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 21:00:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 22:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 22:05:35]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-06-16 22:09:38]

PTAL

[anthonyvd, 2017-06-19 18:47:00]

lgtm

[tmartino, 2017-06-19 18:51:40]

The CQ bit was checked by tmartino@chromium.org

[commit-bot: I haz the power, 2017-06-19 18:52:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 20:01:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497898300294610,
"parent_rev": "b7bde18727ae4970f34a0b14f903d6e501c93a4f", "commit_rev":
"0c486ef46927e0b1aef9f8b352b4aaedebb4ca5b"}

[commit-bot: I haz the power, 2017-06-19 20:01:29]

Description was changed from

==========
[WebPayments] Setting hidden views in view stack invisible

Setting visibility on these views is important, among other
reasons, for screen reader purposes.

BUG=733684
==========

to

==========
[WebPayments] Setting hidden views in view stack invisible

Setting visibility on these views is important, among other
reasons, for screen reader purposes.

BUG=733684

Review-Url: https://codereview.chromium.org/2942943002
Cr-Commit-Position: refs/heads/master@{#480549}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c486ef46927e0b1aef9f8b352b4...
==========

[commit-bot: I haz the power, 2017-06-19 20:01:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0c486ef46927e0b1aef9f8b352b4...