Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2942933002:
[Extensions Bindings] Update permissions_custom_bindings.js (Closed)
Description[Extensions Bindings] Update permissions_custom_bindings.js
Update permissions_custom_bindings.js for native bindings. This involves
the typical delegation to the native bindings for core functionality,
but also involves changing the unusual method of updating event
arguments to the more common argument massager pattern.
BUG=653596
TEST=browser_tests --gtest_filter=PermissionsApiTest.HostSubsets
--native-crx-bindings=1
Review-Url: https://codereview.chromium.org/2942933002
Cr-Commit-Position: refs/heads/master@{#479880}
Committed: https://chromium.googlesource.com/chromium/src/+/6ebcb95f8c4fadb29b69d2fbcbf8c964974e76aa
Patch Set 1 #
Total comments: 2
Patch Set 2 : nits #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
permissions
BUG=
==========
to
==========
[Extensions Bindings] Update permissions_custom_bindings.js
Update permissions_custom_bindings.js for native bindings. This involves
the typical delegation to the native bindings for core functionality,
but also involves changing the unusual method of updating event
arguments to the more common argument massager pattern.
BUG=653596
TEST=browser_tests --gtest_filter=PermissionsApiTest.HostSubsets
--native-crx-bindings=1
==========
rdevlin.cronin@chromium.org changed reviewers: + jbroman@chromium.org, lazyboy@chromium.org
Hey folks, mind taking a quick look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm https://codereview.chromium.org/2942933002/diff/1/extensions/renderer/resourc... File extensions/renderer/resources/permissions_custom_bindings.js (right): https://codereview.chromium.org/2942933002/diff/1/extensions/renderer/resourc... extensions/renderer/resources/permissions_custom_bindings.js:25: for (var i = 0; i < args[0].permissions.length; i += 1) ++i?
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2942933002/diff/1/extensions/renderer/resourc... File extensions/renderer/resources/permissions_custom_bindings.js (right): https://codereview.chromium.org/2942933002/diff/1/extensions/renderer/resourc... extensions/renderer/resources/permissions_custom_bindings.js:25: for (var i = 0; i < args[0].permissions.length; i += 1) On 2017/06/15 21:25:38, lazyboy wrote: > ++i? was copy-pasted from below. Fixed this, and updated a few other spots that jumped out.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org, jbroman@chromium.org Link to the patchset: https://codereview.chromium.org/2942933002/#ps20001 (title: "nits")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497567232643150,
"parent_rev": "6f572e6775095f973220e5ab1c53a340747fbb2d", "commit_rev":
"6ebcb95f8c4fadb29b69d2fbcbf8c964974e76aa"}
Message was sent while issue was closed.
Description was changed from
==========
[Extensions Bindings] Update permissions_custom_bindings.js
Update permissions_custom_bindings.js for native bindings. This involves
the typical delegation to the native bindings for core functionality,
but also involves changing the unusual method of updating event
arguments to the more common argument massager pattern.
BUG=653596
TEST=browser_tests --gtest_filter=PermissionsApiTest.HostSubsets
--native-crx-bindings=1
==========
to
==========
[Extensions Bindings] Update permissions_custom_bindings.js
Update permissions_custom_bindings.js for native bindings. This involves
the typical delegation to the native bindings for core functionality,
but also involves changing the unusual method of updating event
arguments to the more common argument massager pattern.
BUG=653596
TEST=browser_tests --gtest_filter=PermissionsApiTest.HostSubsets
--native-crx-bindings=1
Review-Url: https://codereview.chromium.org/2942933002
Cr-Commit-Position: refs/heads/master@{#479880}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ebcb95f8c4fadb29b69d2fbcbf8...
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6ebcb95f8c4fadb29b69d2fbcbf8... |
